Conversation
…m createRelease - Add prPreview.yml: builds extension on every PR commit and publishes as a GitHub release - Add runIntegrationTests.yml: manual workflow for running tests with INTEGRATION_MODE=true - Remove manifest v2 update steps from createRelease.yml Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR updates Freighter Extension’s CI/CD to better support trunk-based development by separating integration-mode E2E testing, adding PR preview build releases, and introducing an automated release-branch + version-bump PR workflow.
Changes:
- Simplifies
runTestsby removing release-branch version auto-bumping and always runningyarn test:e2e. - Adds an ad-hoc
runIntegrationTestsworkflow intended to run integration-mode E2E tests on demand. - Adds
prPreviewworkflow to build and publish a zipped PR preview via GitHub Releases, plus cleanup on PR close. - Adds
createReleaseworkflow to create a release branch and open version-bump PRs.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| .github/workflows/runTests.yml | Removes release-branch version bump logic; standardizes E2E execution. |
| .github/workflows/runIntegrationTests.yml | New manual workflow for integration-mode CI test runs. |
| .github/workflows/prPreview.yml | New workflow to build, zip, and publish per-PR preview releases (and cleanup). |
| .github/workflows/createRelease.yml | New workflow to create release branches and open version bump PRs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…nd emergency release support Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
| @@ -0,0 +1,91 @@ | |||
| # name: PR Preview | |||
There was a problem hiding this comment.
commenting this out for now because it works, but any GH release automatically pushes a slack notification to the #release channel. I need to disable that notification before enabling this pipeline
There was a problem hiding this comment.
I connected with Kanwal about this. He'll be able to deploy the change needed to suppress Slack notifications next week., Until then, let's keep this commented out
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@piyalbasu I've opened a new pull request, #2663, to work on those changes. Once the pull request is ready, I'll request review from you. |
|
@piyalbasu I've opened a new pull request, #2664, to work on those changes. Once the pull request is ready, I'll request review from you. |
…fix) (#2664) * Initial plan * Fix tag pattern in new-release.yml to match plain semver tags (no v prefix) Co-authored-by: piyalbasu <6789586+piyalbasu@users.noreply.github.com> Agent-Logs-Url: https://github.com/stellar/freighter/sessions/774e2d0a-dd3f-44b9-ae49-778d641f5c0c --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: piyalbasu <6789586+piyalbasu@users.noreply.github.com>
| if [ "$BRANCH_FROM" = "master" ]; then | ||
| RELEASE_BRANCH="release/${APP_VERSION}" | ||
| else | ||
| RELEASE_BRANCH="emergency-release/${APP_VERSION}" | ||
| fi |
There was a problem hiding this comment.
on mobile we name those as simply release and emergency-release since we'll have the v${APP_VERSION} branch merged to it
| run: | | ||
| git config user.name "github-actions[bot]" | ||
| git config user.email "41898282+github-actions[bot]@users.noreply.github.com" | ||
|
|
There was a problem hiding this comment.
on mobile we have this Validate and get available tags step which appears to be missing here
Closes #2642
Goal: To align Freighter Extension's release process with Freighter Mobile's: https://docs.google.com/document/d/1m5-mbE18Zc9KGhWlOgqyuBIStAiynbpHZySS1QmUVV0/edit?tab=t.0
The idea here is to automate the creation of the release branch and the version bump. It should be similar to https://github.com/stellar/freighter-mobile/blob/main/.github/workflows/new-release.yml
This PR also adds a PR Preview job that will create a build artifact on every commit.
CI/CD Automation and Workflow Improvements:
.github/workflows/new-release.ymlto automate the process of creating release branches, updating version numbers in relevant files, and opening pull requests for both release and master branches. This workflow takes version and branch as inputs and ensures consistent versioning across the codebase..github/workflows/prPreview.ymlto automatically build, package, and publish a preview release for each pull request. It updates manifest fields for PR previews, uses BETA icons, and handles cleanup when a PR is closed..github/workflows/runIntegrationTests.ymlto provide a dedicated workflow for running integration and end-to-end tests, including Playwright-based browser tests, with artifact upload for test results.Test Workflow Simplification:
.github/workflows/runTests.ymlthat checked and updated the version number on release branches, as this responsibility is now handled by the new release workflow..github/workflows/runTests.ymlby always runningyarn test:e2e, regardless of the base branch, ensuring consistent test coverage.