Fix prPreview.yml: drop gh run cancel/watch, use exit 1 for missing-secret guard#2663
Closed
Copilot wants to merge 2 commits intofeature/new-release-pipelinefrom
Closed
Fix prPreview.yml: drop gh run cancel/watch, use exit 1 for missing-secret guard#2663Copilot wants to merge 2 commits intofeature/new-release-pipelinefrom
Copilot wants to merge 2 commits intofeature/new-release-pipelinefrom
Conversation
…eeding actions:write Co-authored-by: piyalbasu <6789586+piyalbasu@users.noreply.github.com> Agent-Logs-Url: https://github.com/stellar/freighter/sessions/4fd0da6f-0690-45b6-a831-657189b287a8
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on new release pipeline implementation
Fix prPreview.yml: drop gh run cancel/watch, use exit 1 for missing-secret guard
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gh run cancelrequiresactions: write, but the workflow only declarescontents: write, causing a 403 when secrets are absent. The file was also fully commented out.Changes
prPreview.ymldefinitiongh run cancel ${{ github.run_id }} && gh run watch ${{ github.run_id }}withexit 1in both secret-check steps — fails the job normally with no additional permissions required🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.