Skip to content

Fix prPreview.yml: drop gh run cancel/watch, use exit 1 for missing-secret guard#2663

Closed
Copilot wants to merge 2 commits intofeature/new-release-pipelinefrom
copilot/sub-pr-2660
Closed

Fix prPreview.yml: drop gh run cancel/watch, use exit 1 for missing-secret guard#2663
Copilot wants to merge 2 commits intofeature/new-release-pipelinefrom
copilot/sub-pr-2660

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 24, 2026

gh run cancel requires actions: write, but the workflow only declares contents: write, causing a 403 when secrets are absent. The file was also fully commented out.

Changes

  • Restore workflow: uncomment the entire prPreview.yml definition
  • Fix permission issue: replace gh run cancel ${{ github.run_id }} && gh run watch ${{ github.run_id }} with exit 1 in both secret-check steps — fails the job normally with no additional permissions required
# Before
- if: ${{ env.INDEXER_URL == '' }}
  run: |
    echo "Missing INDEXER_URL"
    gh run cancel ${{ github.run_id }}
    gh run watch ${{ github.run_id }}

# After
- if: ${{ env.INDEXER_URL == '' }}
  run: |
    echo "Missing INDEXER_URL"
    exit 1

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

…eeding actions:write

Co-authored-by: piyalbasu <6789586+piyalbasu@users.noreply.github.com>
Agent-Logs-Url: https://github.com/stellar/freighter/sessions/4fd0da6f-0690-45b6-a831-657189b287a8
Copilot AI changed the title [WIP] [WIP] Address feedback on new release pipeline implementation Fix prPreview.yml: drop gh run cancel/watch, use exit 1 for missing-secret guard Mar 24, 2026
Copilot AI requested a review from piyalbasu March 24, 2026 20:30
@piyalbasu piyalbasu closed this Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants