feat(wallets): refresh the rename wallet modal - #2931
Draft
CassioMG wants to merge 1 commit into
Draft
Conversation
Restyle the rename-wallet modal to match frame 9585-24423: a centered card with a circular close button, a centered identicon, the name input, and Cancel / Set name side by side. "Save" is renamed to "Set name", and the "Rename Wallet" heading and Address line are removed. Update the e2e test's button-text assertion to match the new label.
Contributor
|
PR Preview build is ready: https://github.com/stellar/freighter/releases/tag/untagged-8565efb64d42e48b710d (SDF collaborators only — install instructions in the release description) |
This was referenced Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the Home refresh project.
What changed
The rename-wallet modal, per Figma frame
9585-24423:top: 30%.Xclose button top-right inside the card.Address: G…line.The form itself is untouched — same Formik setup, same 24-character Yup limit, same dispatch.
Two bugs found and fixed while implementing
transform: translateY(-50%)creates a new CSS stacking context, which let the siblingLoadingBackgroundbackdrop sit above the card and swallow every click. Fixed by addingz-index: var(--z-index--banner)to the same wrapper block. Caught by actually clicking it in a browser, not by code review — worth knowing if you centre another overlay this way.variant="primary"was wrong for the "Set name" button. In SDS,primaryis a purple fill;secondaryis the near-white fill with black text that the frame shows (--sds-clr-gray-12background,--sds-clr-base-00text). Usingsecondary.Scoped to avoid conflicts
views/Wallets/styles.scssis shared by three PRs in this batch. This PR changes only the.RenameWalletWrapperblock —.AddWalletWrapperand everything else are untouched. The diff on that file is 5 lines.Merge order
views/Wallets/styles.scss, and it deletes the largest region of that file.extension/e2e-tests/loadAccount.test.ts("Save"→"Set name", since that test asserts the button label). The wallets-list PR rewrites the rename navigation in that same test, so expect a small conflict there — take both changes: the new navigation and the new label.Analytics
Unchanged.
emitMetric(METRIC_NAMES.accountRenamed, { source: "wallets" })is byte-identical, verified by grep.One thing for the designer
The frame's backdrop is
#000000e5— black at ~90%. This PR reuses the existingLoadingBackgroundcomponent at its--activeopacity of 0.6, rather than hardcoding a new rgba or adding a one-off opacity variant for a single modal. If the darker scrim matters visually, that's a deliberate call to make rather than something I'd sneak in.Verification
yarn test:ci— 196/202 suites, 1520/1571 tests, identical to baselineyarn build:extension— cleanyarn test:e2e loadAccount.test.ts— 9 passed / 2 skipped, matching baselineKnown repo issue
yarn build:extension:translationsis broken onmaster(i18next-scanner-webpackneeds.default,extension/webpack.extension.js:3), and the pre-commit hook hides the failure. The one new locale key here was added by hand toenandpt. Worth fixing separately.🤖 Generated with Claude Code