Skip to content

soroban-rpc: Add admin endpoint including pprof debug endpoints - #573

Merged
2opremio merged 3 commits into
stellar:mainfrom
2opremio:add-admin-pprof-port
Apr 11, 2023
Merged

soroban-rpc: Add admin endpoint including pprof debug endpoints#573
2opremio merged 3 commits into
stellar:mainfrom
2opremio:add-admin-pprof-port

Conversation

@2opremio

Copy link
Copy Markdown
Contributor

What

Add admin http endpoint containing pprof debug endpoints

It adds an --admin-endpoint flag (matching the normal --endpoint flag), which indicates where to listen.

For instance, when providing --admin-endpoint http://localhost:9000 the endpoints like the following will be exposed:

http://localhost:9000/debug/pprof/
http://localhost:9000/debug/pprof/cmdline
http://localhost:9000/debug/pprof/profile
http://localhost:9000/debug/pprof/symbol
http://localhost:9000/debug/pprof/trace
...

Depends on #566

Why

Closes #498 and paces the way for #496 which also needs an admin base endpoint

Known limitations

[TODO or N/A]

@2opremio
2opremio requested review from paulbellamy and tamirms April 10, 2023 16:28
@2opremio
2opremio force-pushed the add-admin-pprof-port branch from 3305dbf to 60c6f68 Compare April 10, 2023 16:29
Comment thread cmd/soroban-rpc/internal/daemon/daemon.go Outdated
Comment thread cmd/soroban-rpc/internal/daemon/daemon.go
Comment thread cmd/soroban-rpc/internal/daemon/daemon.go
@2opremio
2opremio force-pushed the add-admin-pprof-port branch from b70b060 to 9b4ce86 Compare April 11, 2023 10:15
@2opremio

Copy link
Copy Markdown
Contributor Author

@tsachiherman PTAL, can't merge without your confirmation.

Comment thread cmd/soroban-rpc/internal/daemon/daemon.go
@2opremio
2opremio enabled auto-merge (squash) April 11, 2023 14:57
@tsachiherman

Copy link
Copy Markdown
Contributor

@tsachiherman PTAL, can't merge without your confirmation.

I blocked this one only for the nil issue I pointed out ( and you fixed ).

@2opremio
2opremio merged commit 6c91383 into stellar:main Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

soroban-rpc: Add configurable pprof support

4 participants