soroban-rpc: Add admin endpoint including pprof debug endpoints - #573
Merged
Conversation
2opremio
force-pushed
the
add-admin-pprof-port
branch
from
April 10, 2023 16:29
3305dbf to
60c6f68
Compare
tsachiherman
suggested changes
Apr 10, 2023
2opremio
force-pushed
the
add-admin-pprof-port
branch
from
April 11, 2023 10:15
b70b060 to
9b4ce86
Compare
tamirms
approved these changes
Apr 11, 2023
Contributor
Author
|
@tsachiherman PTAL, can't merge without your confirmation. |
paulbellamy
reviewed
Apr 11, 2023
tsachiherman
approved these changes
Apr 11, 2023
2opremio
enabled auto-merge (squash)
April 11, 2023 14:57
Contributor
I blocked this one only for the nil issue I pointed out ( and you fixed ). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add admin http endpoint containing pprof debug endpoints
It adds an
--admin-endpointflag (matching the normal--endpointflag), which indicates where to listen.For instance, when providing
--admin-endpoint http://localhost:9000the endpoints like the following will be exposed:Depends on #566
Why
Closes #498 and paces the way for #496 which also needs an admin base endpoint
Known limitations
[TODO or N/A]