pyright: Turn off reportMissingImports only in tests directory#1215
pyright: Turn off reportMissingImports only in tests directory#1215mulkieran merged 1 commit intostratis-storage:masterfrom
Conversation
WalkthroughReplaces the global Pyright Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
pyproject.toml (1)
10-10: Prefer severity string over boolean for future-proofing.Use "none" instead of false to align with documented rule severities and avoid potential schema drift.
- { root = "tests", reportMissingImports = false } + { root = "tests", reportMissingImports = "none" }Docs/examples show per-environment rule severities as strings. (docs.basedpyright.com)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
pyproject.toml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: test-runs (3.13)
- GitHub Check: test-runs (3.12)
🔇 Additional comments (1)
pyproject.toml (1)
8-11: Scoped suppression looks good.Limiting reportMissingImports to tests via executionEnvironments matches the PR goal and the TOML inline-table syntax here is valid for Pyright configs. (fpfortkamp.com)
e5b7bbc to
2be9158
Compare
Signed-off-by: mulhern <amulhern@redhat.com>
Summary by CodeRabbit
No user-facing changes.