Skip to content

Revert "Ignore pyright reportMissingImport error"#1232

Merged
mulkieran merged 1 commit intostratis-storage:masterfrom
mulkieran:revert-pyright-temporary-fix
Oct 30, 2025
Merged

Revert "Ignore pyright reportMissingImport error"#1232
mulkieran merged 1 commit intostratis-storage:masterfrom
mulkieran:revert-pyright-temporary-fix

Conversation

@mulkieran
Copy link
Copy Markdown
Member

@mulkieran mulkieran commented Oct 30, 2025

Summary by CodeRabbit

  • Chores
    • Removed workaround configuration, transitioning to default environment handling for type checking.

@mulkieran mulkieran self-assigned this Oct 30, 2025
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Oct 30, 2025

Walkthrough

The executionEnvironments workaround block has been removed from the Pyright configuration in pyproject.toml. This eliminates a previous bug mitigation, allowing Pyright to rely on default environment handling instead.

Changes

Cohort / File(s) Change Summary
Pyright configuration cleanup
pyproject.toml
Removed executionEnvironments block from [tool.pyright] section that was previously used as a workaround for a Pyright bug

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Poem

🐰 A buggy workaround fades away,
Pyright's defaults now have their say,
Config grows cleaner, lean and bright,
One less quirk to set things right!

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The PR title "Revert 'Ignore pyright reportMissingImport error'" directly corresponds to the changeset, which removes the executionEnvironments block under [tool.pyright] that was a workaround for a Pyright bug. The title is clear and specific, indicating that the primary change is undoing a previous configuration that suppressed a specific Pyright error, which aligns with the actual modifications shown in the summary. The title is concise, readable, and contains no vague or misleading language.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d7b8869 and 74c5f4a.

📒 Files selected for processing (1)
  • pyproject.toml (0 hunks)
💤 Files with no reviewable changes (1)
  • pyproject.toml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: test-runs (3.13)
  • GitHub Check: test-runs (3.12)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Also, revert "pyright: Turn off reportMissingImports only in tests directory"

It appears that a more recent version of pyright has fixed the bug.

This reverts commit cdb3d1a.

Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran mulkieran moved this to In Review in 2025October Oct 30, 2025
@mulkieran
Copy link
Copy Markdown
Member Author

pyright checks are passing now, no need to wait for the rest.

@mulkieran mulkieran merged commit 6a52b87 into stratis-storage:master Oct 30, 2025
9 checks passed
@mulkieran mulkieran deleted the revert-pyright-temporary-fix branch October 30, 2025 16:54
@github-project-automation github-project-automation Bot moved this from In Review to Done in 2025October Oct 30, 2025
@mulkieran mulkieran moved this from Done to Done(3) in 2025October Nov 4, 2025
@mulkieran mulkieran moved this from Done(3) to Done(4) in 2025October Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

No open projects
Status: Done(4)

Development

Successfully merging this pull request may close these issues.

1 participant