Add HttpContent class#896
Merged
ob-stripe merged 1 commit intointegration-client-refactorfrom Nov 12, 2019
Merged
Conversation
brandur-stripe
approved these changes
Nov 12, 2019
Contributor
brandur-stripe
left a comment
brandur-stripe
left a comment
There was a problem hiding this comment.
Looks good to me. Beautiful tests. Left one comment.
I was just thinking about whether stripe-java is "good", and after many many years of an obvious "no", at some point in the last year we crossed the threshold into a pretty definitive "yes". Nice work.
ptal @ob-stripe
ob-stripe
force-pushed
the
ob-http-content
branch
from
5d21a1f to
49682ed
Compare
ob-stripe
force-pushed
the
ob-http-content
branch
from
49682ed to
c00067e
Compare
ob-stripe
added a commit
that referenced
this pull request
Nov 15, 2019
ob-stripe
added a commit
that referenced
this pull request
Nov 16, 2019
ob-stripe
added a commit
that referenced
this pull request
Dec 10, 2019
ob-stripe
added a commit
that referenced
this pull request
Dec 23, 2019
ob-stripe
added a commit
that referenced
this pull request
Jan 11, 2020
ob-stripe
added a commit
that referenced
this pull request
Jan 14, 2020
ob-stripe
added a commit
that referenced
this pull request
Jan 14, 2020
ob-stripe
added a commit
that referenced
this pull request
Jan 15, 2020
ob-stripe
added a commit
that referenced
this pull request
Jan 15, 2020
ob-stripe
added a commit
that referenced
this pull request
Jan 15, 2020
* Refactor form encoding * Refactor request telemetry * Move HTTP request methods into new `HttpClient` class * Add `StripeRequest` object * Add `HttpClient` abstract class * Stop disabling the DNS cache * Fix deprecation warnings (#895) * Add HttpContent class (#896) * Add Stopwatch class (#897) * Move all request properties in `StripeRequest` (#898) * Remove ApiResource.RequestType (#899) * Add support for automatic request retries (#900) * Minor fixes (#902) * `StringUtils` class & better API key validation (#928) * Remove support for custom `URLStreamHandler` (#927) * Refactor HTTP headers handling (#931) * Add `CaseInsensitiveMap` class * Add `HttpHeaders` class * Use `HttpHeaders` in `StripeRequest` * Use `HttpHeaders` in `StripeResponse` * Address review comments * Modernize `StripeResponse` (#932) * Add `maxNetworkRetries` as a global and per-request setting (#934) * Add `StreamUtils` class (#935) * Remove support for `count` and `total_count` in list objects (#936) * Codegen for openapi e07de1a (#938) * Update README (#939) Co-authored-by: remi-stripe <remi@stripe.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @brandur-stripe @richardm-stripe
cc @stripe/api-libraries
This PR:
HttpContentclass that represents an HTTP request's content, i.e. the body and theContent-Typeheader (which can depend on the body, e.g. for multipart requests the header contains the boundary used to separate fields in the body).FormEncoder.createHttpContent()method that builds and returns anHttpContentinstance as needed (automatically choosing between form-data encoding and multipart encoding depending on whether all the parameters are strings or not)FormEncoder.encodeMultipartParams()methodHttpURLConnectionClientto useHttpContent. The resulting code is a little bit weird, but will be refactored in a future PRMultipartProcessorto write to a providedOutputStreaminstead of directly to a connection'sOutputStreamMultipartProcessor.getBoundary()method (the boundary is now initialized byHttpContent, and is a random UUIDv4 unless explicitly provided)