Add Stopwatch class#897
Merged
ob-stripe merged 1 commit intointegration-client-refactorfrom Nov 12, 2019
Merged
Conversation
brandur-stripe
approved these changes
Nov 12, 2019
Contributor
brandur-stripe
left a comment
brandur-stripe
left a comment
There was a problem hiding this comment.
Not crazy about the sleep calls in tests, but at least you're not sleeping very long ;) Also, seems to be written such that the risk for non-deterministic runs is low.
One minor comment, but LGTM.
ob-stripe
force-pushed
the
ob-stopwatch
branch
from
22c9536 to
8ffa26d
Compare
ob-stripe
added a commit
that referenced
this pull request
Nov 15, 2019
ob-stripe
added a commit
that referenced
this pull request
Nov 16, 2019
ob-stripe
added a commit
that referenced
this pull request
Dec 10, 2019
ob-stripe
added a commit
that referenced
this pull request
Dec 23, 2019
ob-stripe
added a commit
that referenced
this pull request
Jan 11, 2020
ob-stripe
added a commit
that referenced
this pull request
Jan 14, 2020
ob-stripe
added a commit
that referenced
this pull request
Jan 14, 2020
ob-stripe
added a commit
that referenced
this pull request
Jan 15, 2020
ob-stripe
added a commit
that referenced
this pull request
Jan 15, 2020
ob-stripe
added a commit
that referenced
this pull request
Jan 15, 2020
* Refactor form encoding * Refactor request telemetry * Move HTTP request methods into new `HttpClient` class * Add `StripeRequest` object * Add `HttpClient` abstract class * Stop disabling the DNS cache * Fix deprecation warnings (#895) * Add HttpContent class (#896) * Add Stopwatch class (#897) * Move all request properties in `StripeRequest` (#898) * Remove ApiResource.RequestType (#899) * Add support for automatic request retries (#900) * Minor fixes (#902) * `StringUtils` class & better API key validation (#928) * Remove support for custom `URLStreamHandler` (#927) * Refactor HTTP headers handling (#931) * Add `CaseInsensitiveMap` class * Add `HttpHeaders` class * Use `HttpHeaders` in `StripeRequest` * Use `HttpHeaders` in `StripeResponse` * Address review comments * Modernize `StripeResponse` (#932) * Add `maxNetworkRetries` as a global and per-request setting (#934) * Add `StreamUtils` class (#935) * Remove support for `count` and `total_count` in list objects (#936) * Codegen for openapi e07de1a (#938) * Update README (#939) Co-authored-by: remi-stripe <remi@stripe.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @brandur-stripe
cc @stripe/api-libraries
Add a
Stopwatchclass to measure elapsed time, and use it for latency telemetry.The class is basically a port of its namesake from the .NET stdlib. It does a bit more than we need, but it's still fairly straightforward.
This will help further refactors of
HttpURLConnectionClient.