Add maxNetworkRetries as a global and per-request setting

[ob-stripe]

r? @brandur-stripe @richardm-stripe
cc @stripe/api-libraries

I added support for automatic request retries back in #900, but the setting for the max number of retries was set on the HttpClient instance, which users won't be initializing themselves directly in most cases.

In order to make the feature more accessible, this PR changes the setting so that it can be set in one of two ways:

• per request, via RequestOptions.builder().setMaxNetworkRetries(2).build()
• globally, via Stripe.setMaxNetworkRetries(2)

(The former takes precedence over the latter.)

[brandur-stripe]

WFM, but I'd point out that conceptually, having this as a property that's configured per-client makes more sense to me than one that's configured per-request. e.g. I could for example configure one client for api.stripe.com with 3 retries and another for localhost:12111 (stripe-mock) with 0 retries since it's local and unlikely to fail.

That said, I know that stripe-java's HttpClient doesn't really work that way, but if it was more like a client.API like in stripe-go or a StripeClient like in stripe-ruby, per-client would make more sense.

Either way though, agreed that it should be stripped out of the HttpClient constructor (in favor of a setter).

Don't feel too strongly about this though, so will leave it up to you!

LGTM.

[ob-stripe]

Thanks Brandur!

I agree that setting this property per-request is a bit unorthodox, but it's consistent with what we're doing already for e.g. connect and read timeouts. The main benefit is that RequestOptions is something that stripe-java users are already familiar with, so this makes the feature a lot more discoverable (as opposed to creating a custom HttpClient, which nobody is familiar with because this was introduced in this integration branch).

I plan on reintroducing this setting as a property on the client when we make more progress towards the client + services architecture, and it becomes more commonplace for users to instantiate clients directly.

[brandur-stripe]

Works for me. Thanks OB.