Skip to content

♿️(frontend) ensure doc title is h1 for accessibility#2006

Merged
Ovgodd merged 2 commits intomainfrom
fix/accessibility-doc-title-h1
Mar 18, 2026
Merged

♿️(frontend) ensure doc title is h1 for accessibility#2006
Ovgodd merged 2 commits intomainfrom
fix/accessibility-doc-title-h1

Conversation

@Ovgodd
Copy link
Collaborator

@Ovgodd Ovgodd commented Mar 16, 2026

Purpose

In production, the theme config has withTitle: false, which prevents the header from rendering the "Docs" h1. This leaves the page with no h1 at all, breaking heading hierarchy for screen readers and accessibility audit tools (HeadingsMap).

Proposal

  • Always render the <Title headingLevel="h1"> in the header, using sr-only when withTitle is false so it remains accessible to screen readers without visual impact
  • Remove aria-hidden="true" from the Title component so the h1 is exposed to assistive technologies
  • Add className prop support to the Title component

@Ovgodd Ovgodd requested a review from AntoLC March 16, 2026 09:49
@Ovgodd Ovgodd self-assigned this Mar 16, 2026
@Ovgodd Ovgodd linked an issue Mar 16, 2026 that may be closed by this pull request
@Ovgodd Ovgodd force-pushed the fix/accessibility-doc-title-h1 branch 2 times, most recently from 2f55804 to a4b28d5 Compare March 16, 2026 09:51
@Ovgodd Ovgodd moved this from Backlog to In review in LaSuite Docs A11y Mar 16, 2026
@github-actions
Copy link

github-actions bot commented Mar 16, 2026

Size Change: +5 B (0%)

Total Size: 4.23 MB

Filename Size Change
apps/impress/out/_next/static/4df813ab/_buildManifest.js 902 B +902 B (new file) 🆕
apps/impress/out/_next/static/14cc0295/_buildManifest.js 0 B -902 B (removed) 🏆

compressed-size-action

@Ovgodd Ovgodd force-pushed the fix/accessibility-doc-title-h1 branch 4 times, most recently from 81965ec to c844121 Compare March 16, 2026 10:41
@Ovgodd Ovgodd marked this pull request as ready for review March 16, 2026 10:41
@Ovgodd Ovgodd force-pushed the fix/accessibility-doc-title-h1 branch 4 times, most recently from b31b7c9 to 8c6b96e Compare March 16, 2026 11:49
CHANGELOG.md Outdated
- ⬆️(frontend) upgrade Next.js to v16 #1980
- ♿️(frontend) fix aria-label and landmark on document banner state #1986
- 🌐(i18n) add "new window" translation key for waffle aria-label #1984
- ♿️(frontend) ensure doc title is h1 for accessibility #2006
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will have to be moved under "Unreleased".

@Ovgodd Ovgodd force-pushed the fix/accessibility-doc-title-h1 branch 4 times, most recently from 269760d to 2d78ce4 Compare March 18, 2026 08:14
Ovgodd added 2 commits March 18, 2026 10:02
Fix heading hierarchy when withTitle is false in production
Render QuickSearchGroup names and link settings as h2 headings.
@Ovgodd Ovgodd force-pushed the fix/accessibility-doc-title-h1 branch from 2d78ce4 to 5020bc1 Compare March 18, 2026 09:02
@Ovgodd Ovgodd merged commit 5020bc1 into main Mar 18, 2026
26 of 27 checks passed
@Ovgodd Ovgodd deleted the fix/accessibility-doc-title-h1 branch March 18, 2026 09:46
@github-project-automation github-project-automation bot moved this from In review to Done in LaSuite Docs A11y Mar 18, 2026
lunika added a commit that referenced this pull request Mar 19, 2026
Changed

- ♿️(frontend) ensure doc title is h1 for accessibility #2006
- ♿️(frontend) add nb accesses in share button aria-label #2017

Fixed

- 🐛(frontend) fix image resizing when caption #2045
- 🙈(docker) add \*\*/.next to .dockerignore #2034
- ♿️(frontend) fix share modal heading hierarchy #2007
- ♿️(frontend) fix Copy link toast accessibility for screen readers #2029
- ♿️(frontend) fix modal aria-label and name #2014
- ♿️(frontend) fix language dropdown ARIA for screen readers #2020
- ♿️(frontend) fix waffle aria-label spacing for new-window links #2030
- 🐛(backend) stop using add_sibling method to create sandbox document #2084
- 🐛(backend) duplicate a document as last-sibling #2084
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Incorrect heading hierarchy in reading mode

2 participants