♿️(frontend) ensure doc title is h1 for accessibility#2006
Merged
Conversation
2f55804 to
a4b28d5
Compare
|
Size Change: +5 B (0%) Total Size: 4.23 MB
|
81965ec to
c844121
Compare
b31b7c9 to
8c6b96e
Compare
AntoLC
approved these changes
Mar 17, 2026
CHANGELOG.md
Outdated
| - ⬆️(frontend) upgrade Next.js to v16 #1980 | ||
| - ♿️(frontend) fix aria-label and landmark on document banner state #1986 | ||
| - 🌐(i18n) add "new window" translation key for waffle aria-label #1984 | ||
| - ♿️(frontend) ensure doc title is h1 for accessibility #2006 |
Collaborator
There was a problem hiding this comment.
It will have to be moved under "Unreleased".
269760d to
2d78ce4
Compare
Fix heading hierarchy when withTitle is false in production
Render QuickSearchGroup names and link settings as h2 headings.
2d78ce4 to
5020bc1
Compare
lunika
added a commit
that referenced
this pull request
Mar 19, 2026
Changed - ♿️(frontend) ensure doc title is h1 for accessibility #2006 - ♿️(frontend) add nb accesses in share button aria-label #2017 Fixed - 🐛(frontend) fix image resizing when caption #2045 - 🙈(docker) add \*\*/.next to .dockerignore #2034 - ♿️(frontend) fix share modal heading hierarchy #2007 - ♿️(frontend) fix Copy link toast accessibility for screen readers #2029 - ♿️(frontend) fix modal aria-label and name #2014 - ♿️(frontend) fix language dropdown ARIA for screen readers #2020 - ♿️(frontend) fix waffle aria-label spacing for new-window links #2030 - 🐛(backend) stop using add_sibling method to create sandbox document #2084 - 🐛(backend) duplicate a document as last-sibling #2084
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
In production, the theme config has
withTitle: false, which prevents the header from rendering the "Docs"h1. This leaves the page with noh1at all, breaking heading hierarchy for screen readers and accessibility audit tools (HeadingsMap).Proposal
<Title headingLevel="h1">in the header, usingsr-onlywhenwithTitleisfalseso it remains accessible to screen readers without visual impactaria-hidden="true"from theTitlecomponent so theh1is exposed to assistive technologiesclassNameprop support to theTitlecomponent