Skip to content

♿️(frontend) fix Copy link toast accessibility for screen readers#2029

Merged
Ovgodd merged 1 commit intomainfrom
fix/link-copied-vocalized
Mar 18, 2026
Merged

♿️(frontend) fix Copy link toast accessibility for screen readers#2029
Ovgodd merged 1 commit intomainfrom
fix/link-copied-vocalized

Conversation

@Ovgodd
Copy link
Collaborator

@Ovgodd Ovgodd commented Mar 17, 2026

Purpose

Allow screen readers to announce the toast feedback when the "Copy link" button is used (e.g. with the keyboard), so that users get vocal confirmation that the link has been copied.

Proposal

  • Add @react-aria/live-announcer and call announce() in useClipboard after each toast
  • Announce success/error messages with polite for success and assertive for errors

@Ovgodd Ovgodd requested a review from AntoLC March 17, 2026 08:51
@Ovgodd Ovgodd self-assigned this Mar 17, 2026
@Ovgodd Ovgodd force-pushed the fix/link-copied-vocalized branch from aea49f1 to 2704c43 Compare March 17, 2026 08:54
@Ovgodd Ovgodd marked this pull request as ready for review March 17, 2026 08:54
@Ovgodd Ovgodd moved this to In review in LaSuite Docs A11y Mar 17, 2026
@Ovgodd Ovgodd linked an issue Mar 17, 2026 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Mar 17, 2026

Size Change: +298 B (+0.01%)

Total Size: 4.23 MB

Filename Size Change
apps/impress/out/_next/static/1fea0ee3/_buildManifest.js 0 B -902 B (removed) 🏆
apps/impress/out/_next/static/fe214c11/_buildManifest.js 906 B +906 B (new file) 🆕

compressed-size-action

Copy link
Collaborator

@AntoLC AntoLC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can update it here as well ?

{/* Screen reader announcements */}
<div
role="status"
aria-live="polite"
aria-atomic="true"
className="sr-only"
>
{liveAnnouncement}
</div>

"@hocuspocus/provider": "3.4.4",
"@mantine/core": "8.3.14",
"@mantine/hooks": "8.3.14",
"@react-aria/live-announcer": "^3.4.4",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"@react-aria/live-announcer": "^3.4.4",
"@react-aria/live-announcer": "3.4.4",

CHANGELOG.md Outdated
- ⬆️(frontend) upgrade Next.js to v16 #1980
- ♿️(frontend) fix aria-label and landmark on document banner state #1986
- 🌐(i18n) add "new window" translation key for waffle aria-label #1984
- ♿️(frontend) fix Copy link toast accessibility for screen readers #2029
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Under "Unreleased".

@Ovgodd Ovgodd force-pushed the fix/link-copied-vocalized branch 2 times, most recently from 205e1da to e2ea54d Compare March 17, 2026 14:10
@Ovgodd Ovgodd requested a review from AntoLC March 17, 2026 14:11
@Ovgodd Ovgodd force-pushed the fix/link-copied-vocalized branch from e2ea54d to 52a19c7 Compare March 17, 2026 15:41
Add aria-live announcements so screen readers announce the toast feedback.
@Ovgodd Ovgodd force-pushed the fix/link-copied-vocalized branch from 52a19c7 to 8472e66 Compare March 18, 2026 10:51
@Ovgodd Ovgodd merged commit 8472e66 into main Mar 18, 2026
26 of 27 checks passed
@Ovgodd Ovgodd deleted the fix/link-copied-vocalized branch March 18, 2026 11:15
@github-project-automation github-project-automation bot moved this from In review to Done in LaSuite Docs A11y Mar 18, 2026
lunika added a commit that referenced this pull request Mar 19, 2026
Changed

- ♿️(frontend) ensure doc title is h1 for accessibility #2006
- ♿️(frontend) add nb accesses in share button aria-label #2017

Fixed

- 🐛(frontend) fix image resizing when caption #2045
- 🙈(docker) add \*\*/.next to .dockerignore #2034
- ♿️(frontend) fix share modal heading hierarchy #2007
- ♿️(frontend) fix Copy link toast accessibility for screen readers #2029
- ♿️(frontend) fix modal aria-label and name #2014
- ♿️(frontend) fix language dropdown ARIA for screen readers #2020
- ♿️(frontend) fix waffle aria-label spacing for new-window links #2030
- 🐛(backend) stop using add_sibling method to create sandbox document #2084
- 🐛(backend) duplicate a document as last-sibling #2084
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Missing vocalization of the "Link copied" toast

2 participants