♿️(frontend) add nb accesses in share button aria-label#2017
Merged
Conversation
Ovgodd
force-pushed
the
fix/share-button-aria-label-nb-accesses
branch
from
10657c3 to
362ff07
Compare
|
Size Change: +24 B (0%) Total Size: 4.23 MB
|
AntoLC
approved these changes
Mar 17, 2026
CHANGELOG.md
Outdated
| - ⬆️(frontend) upgrade Next.js to v16 #1980 | ||
| - ♿️(frontend) fix aria-label and landmark on document banner state #1986 | ||
| - 🌐(i18n) add "new window" translation key for waffle aria-label #1984 | ||
| - ♿️(frontend) add nb accesses in share button aria-label #2017 |
Ovgodd
force-pushed
the
fix/share-button-aria-label-nb-accesses
branch
3 times, most recently
from
3579660 to
23a455d
Compare
Expose nb_accesses_direct to screen readers when share button shows count.
Ovgodd
force-pushed
the
fix/share-button-aria-label-nb-accesses
branch
from
23a455d to
1172fbe
Compare
lunika
added a commit
that referenced
this pull request
Mar 19, 2026
Changed - ♿️(frontend) ensure doc title is h1 for accessibility #2006 - ♿️(frontend) add nb accesses in share button aria-label #2017 Fixed - 🐛(frontend) fix image resizing when caption #2045 - 🙈(docker) add \*\*/.next to .dockerignore #2034 - ♿️(frontend) fix share modal heading hierarchy #2007 - ♿️(frontend) fix Copy link toast accessibility for screen readers #2029 - ♿️(frontend) fix modal aria-label and name #2014 - ♿️(frontend) fix language dropdown ARIA for screen readers #2020 - ♿️(frontend) fix waffle aria-label spacing for new-window links #2030 - 🐛(backend) stop using add_sibling method to create sandbox document #2084 - 🐛(backend) duplicate a document as last-sibling #2084
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The share button shows the number of users with access, but screen readers don't announce it.
Proposal
nb_accesses_directto the share buttonaria-labelwhen the count is visible