Skip to content

fix(config): interpolate env on load always - #325

Merged
soedirgo merged 2 commits into
mainfrom
fix/config-interpolate-env
Aug 3, 2022
Merged

fix(config): interpolate env on load always#325
soedirgo merged 2 commits into
mainfrom
fix/config-interpolate-env

Conversation

@soedirgo

@soedirgo soedirgo commented Aug 3, 2022

Copy link
Copy Markdown
Member

Fixes #210

Reverts
f8d5613

Don't quite recall why we only interpolate on `supabase start`.
Otherwise it gives:

=== RUN   TestDbRemoteSetCommand/sets_the_remote_database_url
    set_test.go:33:
                Error Trace:    /Users/soedirgo/repos/cli/internal/db/remote/set/set_test.go:33
                Error:          Received unexpected error:
                                Error evaluating "env(AZURE_CLIENT_ID)": environment variable AZURE_CLIENT_ID is unset.
                Test:           TestDbRemoteSetCommand/sets_the_remote_database_url
FAIL    github.com/supabase/cli/internal/db/remote/set  104.862s

from interpolating config env.
@soedirgo
soedirgo requested a review from sweatybridge as a code owner August 3, 2022 06:03
@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 2787239450

  • 28 of 34 (82.35%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 21.504%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/utils/config.go 28 34 82.35%
Totals Coverage Status
Change from base Build 2772753045: -0.05%
Covered Lines: 1101
Relevant Lines: 5120

💛 - Coveralls

@soedirgo
soedirgo merged commit 013daee into main Aug 3, 2022
@soedirgo
soedirgo deleted the fix/config-interpolate-env branch August 3, 2022 16:52
@github-actions

github-actions Bot commented Aug 3, 2022

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 0.32.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

zlotnika pushed a commit to zlotnika/cli that referenced this pull request Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Config.toml env variable replacement fails

3 participants