test(cli-test-helpers): normalize D-Bus keyring noise in parity stderr - #5997
Merged
Coly010 merged 1 commit intoJul 30, 2026
Merged
Conversation
The parity harness only stripped Go's "Keyring is not supported on WSL" line, but on runners with no D-Bus secrets daemon keyring ops fail with "The name org.freedesktop.secrets was not provided by any .service files" inside store.go's "failed to delete credentials: %w" wrapper. This broke the `projects delete --yes` parity e2e on every PR (the TS port intentionally skips Go's no-op credential cleanup). Strip that wording as the same class of keyring-backend availability noise. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
Supabase CLI previewnpx --yes https://pkg.pr.new/supabase/cli/supabase@767ce254504c2a141d00b6ef56a9ce195a29938dPreview package for commit |
Coly010
approved these changes
Jul 30, 2026
Coly010
deleted the
kanad-claude-2026-07-29/parity-normalize-dbus-keyring-noise
branch
July 30, 2026 09:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
projects delete --yesparity e2e is failing on every develop-based PR (e.g. #5993 and unrelated branches). Go's best-effort keyring cleanup inprojects delete(delete.go:46) prints its failure to stderr, and the parity normalizer only strips one of Go's two keyring-failure wordings:Keyring is not supported on WSL(emitted when the D-Bus client fails withexec.ErrNotFound). When the CI runner has a reachable D-Bus session bus but no secrets daemon, go-keyring instead fails withThe name org.freedesktop.secrets was not provided by any .service files, wrapped asfailed to delete credentials: …— which survives normalization and breaks the byte-for-byte stderr comparison. The TS port intentionally skips this no-op cleanup and relies on the harness treating Go's keyring-backend availability noise as environment detail.The failure appeared without any repo change (same test passed and failed on the same rootfs image hours apart on 2026-07-29), pointing at runner-environment drift in D-Bus availability. This extends the existing normalization rule to strip the second wording, with a unit test covering both.
🤖 Generated with Claude Code