feat(cli): enable lazy local stack startup - #6047
Conversation
6a6af48 to
e68a865
Compare
f1e0c43 to
64bea19
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e68a865bb1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
e68a865 to
27b251a
Compare
64bea19 to
89af0f2
Compare
27b251a to
286f811
Compare
89af0f2 to
e2dd44f
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 286f8113f8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
e2dd44f to
f130bfd
Compare
286f811 to
4a65e80
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4a65e80504
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
f130bfd to
ce21004
Compare
49d11ce to
78bd48c
Compare
ce21004 to
fb58086
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 78bd48cab4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
78bd48c to
91f5643
Compare
fb58086 to
e4738fa
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 91f56436f7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
d958c83 to
67ad946
Compare
91f5643 to
452fcbb
Compare
67ad946 to
b9891e0
Compare
452fcbb to
b5a6c0e
Compare
b9891e0 to
6b836fd
Compare
b5a6c0e to
5107339
Compare
6b836fd to
e1d2245
Compare
5107339 to
930ee68
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 930ee68b9e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
e1d2245 to
f1319ef
Compare
930ee68 to
ae7424f
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ae7424fda4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
f1319ef to
e532be6
Compare
e8b8dd6 to
510f771
Compare
eb66904 to
938ee92
Compare
510f771 to
9ecc6e9
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9ecc6e9b12
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
938ee92 to
038fc01
Compare
9ecc6e9 to
dcc1d7d
Compare
038fc01 to
d486dd6
Compare
dcc1d7d to
0a90882
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0a90882e48
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const finalStates = yield* stack.getAllStates(); | ||
| yield* Effect.forEach(finalStates, updateProgress, { discard: true }); | ||
| }).pipe(Effect.ensuring(Fiber.interrupt(fiber))); |
There was a problem hiding this comment.
When the state-stream fiber has updated statesByName for a final Healthy/dormant transition but is suspended before calling prog.advance, this reconciliation observes the state as unchanged and skips it, after which the ensuring immediately interrupts the only fiber that could advance the bar. The new final-state reread therefore still leaves a race where detached/text progress can finish below its maximum and stream-json can emit an incomplete done event; stop and join the watcher before reconciling from an independent snapshot, or synchronize the bookkeeping and output update as one operation. This shared mutable bookkeeping is fresh evidence that the earlier dropped-transition issue remains after the reconciliation change.
Useful? React with 👍 / 👎.
1 participant
Stack layer 7 of 7, based on #6046.
Makes lazy startup the policy for CLI-managed stacks while leaving the package default eager. The shared stack-config mapping applies consistently to start, branch switching, stack updates, and Functions development.