fix(cli): keep kong email templates - #6065
Open
7ttp wants to merge 1 commit into
Open
Conversation
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
jgoux
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
fixes custom auth email templates silently reverting to GoTrue's built-in defaults after
db reset,functions serve(every hot reload) andbranch switchkong reloadre-renders nginx.conf from Kong's default template, dropping the:8088email-templates server that only bring-up's
--nginx-confdefines.Every reload now hands that template back....
Third pass on this argument:
functions serve'sreload fix(cli): match Go's functions serve docker-down error, kong reload args, and secrets filtering #5976 reverted it for Go parity ("reload reuses the prefix bring-up prepared"
it doesn't) and
db resetreload (fixing issue supabase db reset can leave Kong routing to a stale container IP, causing 502 on /auth/v1/* #6016's 502s) shipped bare on the same assumption.Fixing Go's call sites too removes the parity argument,
so this can't be reverted on parity grounds a fourth time. #6017's DNS re-resolution is unchanged.
verified 502→200 on a rotated container IP with the new argv.
Broken stacks self-heal on the next reset.
A template-less container (only one never created by
supabase start, written unconditionally since the start) now fails the reload loudly, fatal indb reset, stderr warning infunctions serve/branch switch......repro / before vs after
Real stack, kong's
StartedAtnever changes (container never restarted):ref:
db resetagainst an already-running stack leaves Kong's outbound template-serving listener (8088) permanently unbound #6059