Skip to content

fix(cli): keep kong email templates - #6065

Open
7ttp wants to merge 1 commit into
supabase:developfrom
7ttp:fix/kong-reload-nginx-template
Open

fix(cli): keep kong email templates#6065
7ttp wants to merge 1 commit into
supabase:developfrom
7ttp:fix/kong-reload-nginx-template

Conversation

@7ttp

@7ttp 7ttp commented Aug 4, 2026

Copy link
Copy Markdown
Member

TL;DR

fixes custom auth email templates silently reverting to GoTrue's built-in defaults after db reset, functions serve (every hot reload) and
branch switch kong reload re-renders nginx.conf from Kong's default template, dropping the :8088
email-templates server that only bring-up's --nginx-conf defines.
Every reload now hands that template back....

Third pass on this argument:

Fixing Go's call sites too removes the parity argument,
so this can't be reverted on parity grounds a fourth time. #6017's DNS re-resolution is unchanged.
verified 502→200 on a rotated container IP with the new argv.
Broken stacks self-heal on the next reset.
A template-less container (only one never created by supabase start, written unconditionally since the start) now fails the reload loudly, fatal in db reset, stderr warning in functions serve/branch switch......

repro / before vs after

Real stack, kong's StartedAt never changes (container never restarted):

0. after supabase start     listeners=[8000 8001 8088 8443 8444]  template=custom ✓
1. after BASELINE db reset  listeners=[8000 8001      8443 8444]  template=REFUSED → built-in default
2. after FIXED    db reset  listeners=[8000 8001 8088 8443 8444]  template=custom ✓

ref:

@7ttp
7ttp requested a review from a team as a code owner August 4, 2026 21:32
@7ttp 7ttp self-assigned this Aug 4, 2026
@7ttp

7ttp commented Aug 4, 2026

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Delightful!

Reviewed commit: 58c8c21414

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

db reset against an already-running stack leaves Kong's outbound template-serving listener (8088) permanently unbound

2 participants