chore: removed the next folder from the cli directory - #6465
Conversation
Supabase CLI previewnpx --yes https://pkg.pr.new/supabase/cli/supabase@3b9c0f0c6bbcd3be597875b64c23ac7c2ddd12cdPreview package for commit |
Coly010
left a comment
There was a problem hiding this comment.
Reviewed the full diff against origin/develop (06af58c) in a local worktree: pnpm types:check, pnpm exec knip-bun, and the full unit (324 files / 5593 tests) + integration (141 files / 3382 tests) suites all pass clean. The next/ → shared/ moves and the release/CI workflow changes (dropping the alpha channel) are internally consistent — traced every non-mechanical rename and found no dangling references.
A few things outside this diff worth a follow-up, since they aren't on the PR description's own "deliberately left untouched" list:
- Root
README.md:132— the onboarding quickstart still runspnpm dev:next -- --help, which now fails withERR_PNPM_NO_SCRIPTsincedev:nextis removed fromapps/cli/package.json(reproduced locally). apps/cli/CLAUDE.md/AGENTS.md— understood these are intentionally deferred per the PR description, but flagging that they currently describe a three-treelegacy/next/sharedarchitecture and a next/-dual-write obligation that no longer applies, and claim next/ is "moving to a dedicated branch" — there's no such branch in the remote; it's just being deleted with git history as the fallback. Worth prioritizing given how directly these files steer both contributors and coding agents working in this package.apps/cli/docs/ui.md— still documents@effect/atom-react/ink/ink-spinneras "the recommended approach" for terminal UI, with examples lifted from the deletedStartDashboard.tsx. None of those packages remain inpackage.jsonafter this PR.
Also worth calling out explicitly in the PR description rather than folding into the general chore: scripts/generate-docs.ts now builds the docs-site command reference from legacyRoot instead of nextRoot — looks like this silently fixes a latent bug where the public CLI reference docs were being generated from the experimental v3 tree instead of the actually-shipped legacy CLI.
next version of the CLI is a scraped project at the moment. Thus, removing these files so as to reduce confusion. If required in future, we can always access these via git history
The legacy CLI and shared functionalities utilised a few functions from next. Moved them to shared and updated all references.
next CLI was released only as alpha This was referenced in multiple docs and GH workflows. Removed those references from wherever possible. Also, removed the alpha release workflow
104376c to
3b9c0f0
Compare
|
Added a disclaimer line in |
Summary
next version of the CLI is a scraped project at the moment. Thus, removing these files so as to reduce confusion.
If required in future, we can always access these via git history.
Brief of changes
next/intosrc/shared/(auth, config, cli/command-docs) with corrected import paths, since legacy actually depends on it.nextcould be removed from tests, test-helpers or docs.Deliberately left untouched
apps/cli/AGENTS.mdandapps/cli/CLAUDE.md— describes the stale two-shell architectureapps/cli/docs/platform-command-generation.md— documents supabase api routes/api request, a feature that only ever existed innext/.apps/cli/docs/go-cli-divergences.mdThe above documents can be changed later once we shift the legacy CLI directly under
src.Checklist
fix(cli): …).pnpm check:allpasses; relevant package tests pass for every touched workspace, andpnpm types:checkpasses for each touched TypeScript workspace (or workspace declaring it).