chore: upgrade Bun to 1.4.1 - #6470
Merged
Merged
Conversation
Contributor
Supabase CLI previewnpx --yes https://pkg.pr.new/supabase/cli/supabase@1a5676cabda3649302d94194deb0bad447e6df34Preview package for commit |
Contributor
There was a problem hiding this comment.
🤖 AI Review
All three Claude findings were verified; Codex reported none. The CI coverage-validation gap is confirmed, the root Vite dependency concern remains uncertain, and the lockfile-variant concern is refuted as normal optional-peer resolution.
Findings
| Severity | Location | Category | Sources | Claim |
|---|---|---|---|---|
| 🟡 MINOR | package.json:43 |
dependencies |
claude | The root vite dependency is unreferenced by root source and undocumented as peer-resolution plumbing, making it vulnerable to unused-dependency cleanup that could break Vitest consumers. |
| 🟡 MINOR | apps/cli/vitest.config.ts:40 |
test-coverage |
claude | CI does not validate that the new V8 provider produces nonempty or adequate coverage, so a silent coverage regression can pass. |
Refuted findings (kept for transparency, not posted as review comments)
pnpm-lock.yaml:465(dependencies): The regenerated lockfile introduces an anomalous third Vitest/coverage peer variant without@<!---->types/node, suggesting duplicate installation or incremental lockfile drift.
Refuted: pnpm-lock.yaml:6434-6463 declares both@<!---->types/nodeand coverage providers as optional Vitest peers. The variant at :12707 still resolves Vite and coverage at :12727-12730, and Vite itself resolves its available optional peers at :12637-12649. The trusted base lockfile already uses shortened peer suffixes whose dependency edges resolve fuller Vite snapshots, so this is normal pnpm peer-context encoding rather than evidence of corruption.
Stats
Claude findings: 3 · Codex findings: 0 · Confirmed: 1 · Refuted: 1 · Uncertain: 1
Models: claude-opus-5 + gpt-5.6-sol · Trigger: auto · Workflow run
This review runs once per PR. A maintainer can request another with a /ai-review comment.
Coly010
approved these changes
Sep 4, 2026
kanadgupta
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bun 1.4.1 fixes the Vitest/c8 V8 coverage merge failure that previously blocked this migration.
Binary size impact
Compared locally built Bun 1.4.1 executables with the checksum-verified v2.117.0-beta.18 production artifacts, which embed Bun 1.4.0.
The compressed release archives are also 0.37%-1.54% smaller.
The comparison is not fully runtime-isolated: the current source is one commit beyond the production tag, and the local macOS binaries lack CI release signing. Linux and Windows provide the cleanest indication of the Bun upgrade size impact.