fix(ansible): drop no-op zpool item and filter - #2322
Merged
mmlb merged 1 commit intoJul 29, 2026
Conversation
zsmalloc has been zswap's default allocator since kernel 6.3 (Sept 2023), and Ubuntu noble has always shipped >= 6.8, so explicitly writing zpool=zsmalloc was a no-op on every kernel this fleet has run. Kernels >= 6.18 dropped the param entirely. Drop the item instead of guarding it, since setting it never did anything. No guard needed for the remaining params either: the original failure log shows compressor, max_pool_percent, and enabled all wrote successfully on the newest kernel observed (7.0.0-1009-aws) -- zpool was the only one that failed. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
brainrake
force-pushed
the
martonboros/psql-1548-followup-drop-noop-zpool-item
branch
from
July 28, 2026 15:38
fe3170c to
902e411
Compare
brainrake
marked this pull request as ready for review
July 28, 2026 15:39
brainrake
enabled auto-merge
July 28, 2026 15:40
Collaborator
Author
brainrake
changed the title
soedirgo
approved these changes
Jul 29, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Jul 29, 2026
Collaborator
|
lgtm |
hunleyd
added a commit
that referenced
this pull request
Aug 8, 2026
…c-spool-path-defaults-onto-the-10gb-root-volume * origin/develop: (26 commits) Lots of bootstrap script clean ups (#2326) ci: Fix nix-build PUSH_TO_CACHE (#2345) ci/nix-install-ephemeral: Drop sticky disk config (#2346) chore: bump postgres_release to cut fresh AMIs (includes #2334) (#2349) fix(multigres): stop base config data_directory from overriding pooler data dir (#2344) fix(cron): remove unnecessary TRIGGER grant on cron.job_run_details from postgres (#2334) chore: enable extension version restriction (warn) and cut AMIs (#2315) feat(nix): add site-env packages for rolling instance updates (#2283) ci: resolve package install sha from a flake input override (#2327) fix(multigres): remove dangling wal-g include from postgresql.conf (#2338) fix: Allow test CI pipelines to use old Int CA access. For staging only (#2330) chore(nix): remove maintainers field from package definitions (#2280) chore: bump multigres to b713432 (#2323) ci: Use arm-native-runner for kvm builds on aarch64-linux (#2319) Whole lot of ansible clean up (#2272) fix(ansible): drop no-op zpool loop item from zswap task (#2322) ci: Fix dockerhub-release-matrix matrix generation (#2320) chore: bump pgctld (#2318) fix(ansible): skip zswap params the kernel does not expose (#2321) feat(docker): add Dockerfile-supabase base image and rewrite Dockerfile-multigres as layered image (#2160) ...
hunleyd
added a commit
that referenced
this pull request
Aug 8, 2026
…nix-pkg-for-pgbackrest * origin/develop: (36 commits) Lots of bootstrap script clean ups (#2326) ci: Fix nix-build PUSH_TO_CACHE (#2345) ci/nix-install-ephemeral: Drop sticky disk config (#2346) chore: bump postgres_release to cut fresh AMIs (includes #2334) (#2349) fix(multigres): stop base config data_directory from overriding pooler data dir (#2344) fix(cron): remove unnecessary TRIGGER grant on cron.job_run_details from postgres (#2334) chore: enable extension version restriction (warn) and cut AMIs (#2315) feat(nix): add site-env packages for rolling instance updates (#2283) ci: resolve package install sha from a flake input override (#2327) fix(multigres): remove dangling wal-g include from postgresql.conf (#2338) fix: Allow test CI pipelines to use old Int CA access. For staging only (#2330) chore(nix): remove maintainers field from package definitions (#2280) chore: bump multigres to b713432 (#2323) ci: Use arm-native-runner for kvm builds on aarch64-linux (#2319) Whole lot of ansible clean up (#2272) fix(ansible): drop no-op zpool loop item from zswap task (#2322) ci: Fix dockerhub-release-matrix matrix generation (#2320) chore: bump pgctld (#2318) fix(ansible): skip zswap params the kernel does not expose (#2321) feat(docker): add Dockerfile-supabase base image and rewrite Dockerfile-multigres as layered image (#2160) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Drop the
zpool: zsmallocloop item entirely — no guard needed.Why
@brainrake raised in #2321 (comment) if the default already matches the value we set, we should remove the param rather than conditionally skip it.
Confirmed: zsmalloc has been zswap's default allocator since kernel 6.3 (patch, Sept 2023). Ubuntu noble has always shipped >= 6.8, so
echo zsmalloc > .../parameters/zpoolwas a no-op.Related: PSQL-1548