Add Atmospheric Corrections and Bounds [OTA-120] #1131
Conversation
fpezzinosn
force-pushed
the
fpezzinosn/OTA-120
branch
from
c8e70e3 to
c36f4e1
Compare
fpezzinosn
force-pushed
the
fpezzinosn/OTA-120
branch
from
c36f4e1 to
13e0b06
Compare
spec/yaml/swiftnav/sbp/ssr.yaml
Outdated
| type: u8 | ||
| desc: SSR Solution ID. | ||
|
|
||
| - MSG_SSR_STEC_CORRECTION_NEW: |
There was a problem hiding this comment.
I'll look for a better name to differentiate it with the existing message, _NEW isn't the best of suffixes
There was a problem hiding this comment.
Standard procedure here is to add _DEP (or _DEP_A if _DEP already exists) for the existing message and have this new message occupy the old name. I would go ahead and do that in this PR since these messages should be treated like the real thing.
There was a problem hiding this comment.
And what happens with the IDs of the messages?
The message validator threw the following Previous ID: 1531, Current ID: 1533, so I guess I should have kept the original ID.
There was a problem hiding this comment.
@isaactorz ^^ this is a bug with the message validator that we didn't notice during review, it's a common pattern to rename messages (the ID and contents of the message must remain the same)
fpezzinosn
force-pushed
the
fpezzinosn/OTA-120
branch
from
13e0b06 to
73f5220
Compare
Co-authored-by: Jason Mobarak <jason@swift-nav.com>
* Add support for SSR_ORBIT_CLOCK_BOUNDS message [OTA-65] (#1108) * Add support for MSG_SSR_CODE_PHASE_BIASES_BOUNDS message [OTA-119] (#1127) * Add Atmospheric Corrections and Bounds [OTA-120] (#1131) Co-authored-by: Jason Mobarak <jason@swift-nav.com> * Add support for MSG_SSR_ORBIT_CLOCK_BOUNDS_DEGRADATION message [OTA-133] (#1137) * Add Integrity Flags messages [OTA-121] (#1132) * Add transformation parameter message [OTA-149] (#1144) * Add leap second message [OTA-148] (#1145) * Clean up the documentation for the new messages [OTA-150] (#1149) Co-authored-by: swiftnav-svc-jenkins <42622338+swiftnav-svc-jenkins@users.noreply.github.com> Co-authored-by: Jason Mobarak <jason@swift-nav.com> * Updates messages to ICD v1.2 [OTA-161] (#1155) * make all Co-authored-by: Jason Mobarak <jason@swift-nav.com> Co-authored-by: swiftnav-svc-jenkins <42622338+swiftnav-svc-jenkins@users.noreply.github.com>
Description
@swift-nav/devinfra
Added 3 new messages related to Atmospheric Corrections and Bounds
API compatibility
Does this change introduce a API compatibility risk?
No, just adding new messages.
API compatibility plan
If the above is "Yes", please detail the compatibility (or migration) plan:
JIRA Reference
https://swift-nav.atlassian.net/browse/OTA-120