Skip to content

Conversation

@fpezzinosn
Copy link
Contributor

Description

@swift-nav/devinfra

Cleaned up the documentation for the new staged messages.

API compatibility

Does this change introduce a API compatibility risk?

No, just docstrings updates

API compatibility plan

If the above is "Yes", please detail the compatibility (or migration) plan:

JIRA Reference

https://swift-nav.atlassian.net/browse/OTA-150

@fpezzinosn fpezzinosn requested review from a team, notoriaga and silverjam as code owners May 18, 2022 22:53
Copy link
Contributor Author

@fpezzinosn fpezzinosn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@silverjam After fixing the overflow in the units columns, the message structure table for MSG SSR GRIDDED CORRECTION BOUNDS, MSG SSR ORBIT CLOCK BOUNDS and MSG SSR ORBIT CLOCK BOUNDS DEGRADATION still clips the page. I guess a solution could be to write shorter descriptions, but then I'm afraid some information will be missing from the document.

@silverjam
Copy link
Contributor

@silverjam After fixing the overflow in the units columns, the message structure table for MSG SSR GRIDDED CORRECTION BOUNDS, MSG SSR ORBIT CLOCK BOUNDS and MSG SSR ORBIT CLOCK BOUNDS DEGRADATION still clips the page. I guess a solution could be to write shorter descriptions, but then I'm afraid some information will be missing from the document.

We will need to customize rendering for these messages or move the information elsewhere. Would it make sense to create a dedicated page/table that explains things in more detail or do we need to leave everything in this table?

@fpezzinosn fpezzinosn force-pushed the fpezzinosn/OTA-150 branch from de845c5 to d4c3256 Compare May 19, 2022 15:52
@fpezzinosn
Copy link
Contributor Author

@silverjam After fixing the overflow in the units columns, the message structure table for MSG SSR GRIDDED CORRECTION BOUNDS, MSG SSR ORBIT CLOCK BOUNDS and MSG SSR ORBIT CLOCK BOUNDS DEGRADATION still clips the page. I guess a solution could be to write shorter descriptions, but then I'm afraid some information will be missing from the document.

We will need to customize rendering for these messages or move the information elsewhere. Would it make sense to create a dedicated page/table that explains things in more detail or do we need to leave everything in this table?

I've moved the repeated explanations to notes in the description and then added a See Note 1 for those. I also abbreviated some common terms. Now all the tables fit.

@fpezzinosn
Copy link
Contributor Author

@isaactorz Do you know why the validator is failing at the GPS_LEAP_SECOND message? It says that the number of fields is changing, but I didn't modify that in this PR. I only modified docstrings.

@silverjam
Copy link
Contributor

Did MSG_GPS_LEAP_SECOND change in this PR?

INFO:root:Processing Definition: 570 (current: MSG_GPS_LEAP_SECOND, previous: MSG_GPS_LEAP_SECOND)
...
RuntimeError: Breaking Message Mutation Detected!
Number of fields has changed!

@silverjam
Copy link
Contributor

Or... maybe need to add a special case for stubbed messages to the validator.

@fpezzinosn fpezzinosn merged commit 59b1c54 into staging May 19, 2022
@fpezzinosn fpezzinosn deleted the fpezzinosn/OTA-150 branch May 19, 2022 22:01
fpezzinosn added a commit that referenced this pull request Jun 17, 2022
Co-authored-by: swiftnav-svc-jenkins <42622338+swiftnav-svc-jenkins@users.noreply.github.com>
Co-authored-by: Jason Mobarak <jason@swift-nav.com>
fpezzinosn added a commit that referenced this pull request Jun 17, 2022
* Add support for SSR_ORBIT_CLOCK_BOUNDS message [OTA-65] (#1108)

* Add support for MSG_SSR_CODE_PHASE_BIASES_BOUNDS message [OTA-119] (#1127)

* Add Atmospheric Corrections and Bounds [OTA-120] (#1131)

Co-authored-by: Jason Mobarak <jason@swift-nav.com>

* Add support for MSG_SSR_ORBIT_CLOCK_BOUNDS_DEGRADATION message [OTA-133] (#1137)

* Add Integrity Flags messages [OTA-121] (#1132)

* Add transformation parameter message [OTA-149] (#1144)

* Add leap second message [OTA-148] (#1145)

* Clean up the documentation for the new messages [OTA-150] (#1149)

Co-authored-by: swiftnav-svc-jenkins <42622338+swiftnav-svc-jenkins@users.noreply.github.com>
Co-authored-by: Jason Mobarak <jason@swift-nav.com>

* Updates messages to ICD v1.2 [OTA-161] (#1155)

* make all

Co-authored-by: Jason Mobarak <jason@swift-nav.com>
Co-authored-by: swiftnav-svc-jenkins <42622338+swiftnav-svc-jenkins@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants