-
Notifications
You must be signed in to change notification settings - Fork 97
Clean up the documentation for the new messages [OTA-150] #1149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fpezzinosn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@silverjam After fixing the overflow in the units columns, the message structure table for MSG SSR GRIDDED CORRECTION BOUNDS, MSG SSR ORBIT CLOCK BOUNDS and MSG SSR ORBIT CLOCK BOUNDS DEGRADATION still clips the page. I guess a solution could be to write shorter descriptions, but then I'm afraid some information will be missing from the document.
We will need to customize rendering for these messages or move the information elsewhere. Would it make sense to create a dedicated page/table that explains things in more detail or do we need to leave everything in this table? |
Triggered-By: cmake 63396d60278f8b92e1f8f71696110a3309e3ee23 Upstream-PR: http://github.com/swift-nav/cmake/pull/115
de845c5 to
d4c3256
Compare
I've moved the repeated explanations to notes in the description and then added a See Note 1 for those. I also abbreviated some common terms. Now all the tables fit. |
|
@isaactorz Do you know why the validator is failing at the |
|
Did MSG_GPS_LEAP_SECOND change in this PR? |
|
Or... maybe need to add a special case for stubbed messages to the validator. |
Co-authored-by: swiftnav-svc-jenkins <42622338+swiftnav-svc-jenkins@users.noreply.github.com> Co-authored-by: Jason Mobarak <jason@swift-nav.com>
* Add support for SSR_ORBIT_CLOCK_BOUNDS message [OTA-65] (#1108) * Add support for MSG_SSR_CODE_PHASE_BIASES_BOUNDS message [OTA-119] (#1127) * Add Atmospheric Corrections and Bounds [OTA-120] (#1131) Co-authored-by: Jason Mobarak <jason@swift-nav.com> * Add support for MSG_SSR_ORBIT_CLOCK_BOUNDS_DEGRADATION message [OTA-133] (#1137) * Add Integrity Flags messages [OTA-121] (#1132) * Add transformation parameter message [OTA-149] (#1144) * Add leap second message [OTA-148] (#1145) * Clean up the documentation for the new messages [OTA-150] (#1149) Co-authored-by: swiftnav-svc-jenkins <42622338+swiftnav-svc-jenkins@users.noreply.github.com> Co-authored-by: Jason Mobarak <jason@swift-nav.com> * Updates messages to ICD v1.2 [OTA-161] (#1155) * make all Co-authored-by: Jason Mobarak <jason@swift-nav.com> Co-authored-by: swiftnav-svc-jenkins <42622338+swiftnav-svc-jenkins@users.noreply.github.com>
Description
@swift-nav/devinfra
Cleaned up the documentation for the new staged messages.
API compatibility
Does this change introduce a API compatibility risk?
No, just docstrings updates
API compatibility plan
If the above is "Yes", please detail the compatibility (or migration) plan:
JIRA Reference
https://swift-nav.atlassian.net/browse/OTA-150