-
Notifications
You must be signed in to change notification settings - Fork 97
Updates messages to ICD v1.2 [OTA-161] #1155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@swift-nav/devinfra Ready for review! |
silverjam
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming message content has already been approved then this looks good to me. Hopefully the PDF docs look reasonable too?
I did some spot checks on things that looked questionable and it looks fine, but not sure if a more thorough read through has been done already. |
The two new fields for Gridded Correction Bounds made the table overflow (again), so I had to abridge some of the descriptions (Hopefully not beyond the point of usefulness). I also did a comparison with the current ICD, and unless I missed something, everything looks good. |
* Add support for SSR_ORBIT_CLOCK_BOUNDS message [OTA-65] (#1108) * Add support for MSG_SSR_CODE_PHASE_BIASES_BOUNDS message [OTA-119] (#1127) * Add Atmospheric Corrections and Bounds [OTA-120] (#1131) Co-authored-by: Jason Mobarak <jason@swift-nav.com> * Add support for MSG_SSR_ORBIT_CLOCK_BOUNDS_DEGRADATION message [OTA-133] (#1137) * Add Integrity Flags messages [OTA-121] (#1132) * Add transformation parameter message [OTA-149] (#1144) * Add leap second message [OTA-148] (#1145) * Clean up the documentation for the new messages [OTA-150] (#1149) Co-authored-by: swiftnav-svc-jenkins <42622338+swiftnav-svc-jenkins@users.noreply.github.com> Co-authored-by: Jason Mobarak <jason@swift-nav.com> * Updates messages to ICD v1.2 [OTA-161] (#1155) * make all Co-authored-by: Jason Mobarak <jason@swift-nav.com> Co-authored-by: swiftnav-svc-jenkins <42622338+swiftnav-svc-jenkins@users.noreply.github.com>
Description
@swift-nav/devinfra
Updates the name of two navigation messages to better reflect their purpose.
Also updates how the bitmask field should be interpreted in the Integrity Flags messages.
There is also an update on how to interpret the Bound values for the Orbit and Clock Bound message.
The frame transformation message was updated to use fixed-length null-terminated strings for the frames names.
The Gridded Correction Bounds message has two new fields.
API compatibility
There's no change in the fields of the messages themselves, only on how the data should be interpreted.
API compatibility plan
If the above is "Yes", please detail the compatibility (or migration) plan:
JIRA Reference
https://swift-nav.atlassian.net/browse/OTA-161