Skip to content

Conversation

@fpezzinosn
Copy link
Contributor

@fpezzinosn fpezzinosn commented Jun 2, 2022

Description

@swift-nav/devinfra

Updates the name of two navigation messages to better reflect their purpose.
Also updates how the bitmask field should be interpreted in the Integrity Flags messages.
There is also an update on how to interpret the Bound values for the Orbit and Clock Bound message.
The frame transformation message was updated to use fixed-length null-terminated strings for the frames names.
The Gridded Correction Bounds message has two new fields.

API compatibility

There's no change in the fields of the messages themselves, only on how the data should be interpreted.

API compatibility plan

If the above is "Yes", please detail the compatibility (or migration) plan:

JIRA Reference

https://swift-nav.atlassian.net/browse/OTA-161

@fpezzinosn fpezzinosn requested review from a team, notoriaga and silverjam as code owners June 2, 2022 23:46
@fpezzinosn fpezzinosn self-assigned this Jun 2, 2022
@fpezzinosn
Copy link
Contributor Author

@swift-nav/devinfra Ready for review!

@fpezzinosn fpezzinosn requested review from notoriaga and silverjam and removed request for notoriaga and silverjam June 9, 2022 20:00
Copy link
Contributor

@silverjam silverjam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming message content has already been approved then this looks good to me. Hopefully the PDF docs look reasonable too?

@silverjam
Copy link
Contributor

Assuming message content has already been approved then this looks good to me. Hopefully the PDF docs look reasonable too?

I did some spot checks on things that looked questionable and it looks fine, but not sure if a more thorough read through has been done already.

@fpezzinosn
Copy link
Contributor Author

Assuming message content has already been approved then this looks good to me. Hopefully the PDF docs look reasonable too?

I did some spot checks on things that looked questionable and it looks fine, but not sure if a more thorough read through has been done already.

The two new fields for Gridded Correction Bounds made the table overflow (again), so I had to abridge some of the descriptions (Hopefully not beyond the point of usefulness). I also did a comparison with the current ICD, and unless I missed something, everything looks good.

@fpezzinosn fpezzinosn merged commit b5850d1 into staging Jun 9, 2022
@fpezzinosn fpezzinosn deleted the fpezzinosn/OTA-161 branch June 9, 2022 21:51
fpezzinosn added a commit that referenced this pull request Jun 17, 2022
* Add support for SSR_ORBIT_CLOCK_BOUNDS message [OTA-65] (#1108)

* Add support for MSG_SSR_CODE_PHASE_BIASES_BOUNDS message [OTA-119] (#1127)

* Add Atmospheric Corrections and Bounds [OTA-120] (#1131)

Co-authored-by: Jason Mobarak <jason@swift-nav.com>

* Add support for MSG_SSR_ORBIT_CLOCK_BOUNDS_DEGRADATION message [OTA-133] (#1137)

* Add Integrity Flags messages [OTA-121] (#1132)

* Add transformation parameter message [OTA-149] (#1144)

* Add leap second message [OTA-148] (#1145)

* Clean up the documentation for the new messages [OTA-150] (#1149)

Co-authored-by: swiftnav-svc-jenkins <42622338+swiftnav-svc-jenkins@users.noreply.github.com>
Co-authored-by: Jason Mobarak <jason@swift-nav.com>

* Updates messages to ICD v1.2 [OTA-161] (#1155)

* make all

Co-authored-by: Jason Mobarak <jason@swift-nav.com>
Co-authored-by: swiftnav-svc-jenkins <42622338+swiftnav-svc-jenkins@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants