Skip to content

5 - Issue #96 Merged swagger generated classes #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 38 commits into from
Jun 17, 2019
Merged

5 - Issue #96 Merged swagger generated classes #173

merged 38 commits into from
Jun 17, 2019

Conversation

@rg911
Copy link
Contributor

@rg911 rg911 commented Jun 12, 2019

  • Auto generated api client typescript code by using Swagger CodeGen (typescript-node) template.
  • Updated http repositories to use new generated class.

** Dependant:

rg911 added 8 commits June 11, 2019 19:41
@rg911
Added symbol#93
aff8179 
Merged encoders from Lib into SDK
@rg911
Added symbol#94
6a24240 
Merged crypto implementation
@rg911
Added unit test
f3840c9
@rg911
Added symbol#170
f82c312 
Merged existing buffers and schemas
@rg911
Added symbol#95
6c41ef5 
Merged transaction builder from Library
@rg911
Applied transaction builders to transaction models
db91428
@rg911
Updated licenses
ad538ef
@rg911
Added symbol#96
fa2a7c7 
Merged swagger generated classes
@rg911 rg911 changed the title Issue #96 Merged swagger generated classes 5 - Issue #96 Merged swagger generated classes Jun 12, 2019
rg911 and others added 21 commits June 12, 2019 22:47
@rg911
Fixed accountProperty transaction modification type field name mismat…
7d15023 
…ch bug
@rg911
Updated account decrypt message parameter name.
a5f888b 
As the public account can also be sender's account
@rg911
Fixed doc
97a7c69
@evias
Merge pull request symbol#168 from rg911/task/g93_merge_encoders
c15999a 
1 - Issue symbol#93 Merged encoders from Lib into SDK
@rg911
Added symbol#94
4262dab 
Merged crypto implementation
@rg911
Added unit test
7daa764
@rg911
Merge branch 'task/g94_merge_crypto_implementation' of github.com:rg9…
08e4bea 
…11/nem2-sdk-typescript-javascript into task/g94_merge_crypto_implementation
@evias
Merge pull request symbol#169 from rg911/task/g94_merge_crypto_implem…
1007912 
…entation

2 - Issue: symbol#94 Merge crypto implementation into SDK
@rg911
Added symbol#170
ae4224a 
Merged existing buffers and schemas
@rg911
Merge branch 'task/g170_merge_existing_buffer_schema' of github.com:r…
78ee613 
…g911/nem2-sdk-typescript-javascript into task/g170_merge_existing_buffer_schema
@evias
Merge pull request symbol#171 from rg911/task/g170_merge_existing_buf…
8c580c1 
…fer_schema

3 - Issue symbol#170 Merged existing buffers and schemas
@rg911
Added symbol#95
833b59d 
Merged transaction builder from Library
@rg911
Applied transaction builders to transaction models
5333811
@rg911
Updated licenses
0cab0c4
@rg911
Fixed accountProperty transaction modification type field name mismat…
227b8f5 
…ch bug
@rg911
Merge branch 'task/g95_merge_library_transaction_builder' of github.c…
ec97c84 
…om:rg911/nem2-sdk-typescript-javascript into task/g95_merge_library_transaction_builder
@rg911
Removed lib namespaceMosaic id generator nem2-lib reference
e189f6a
@evias
Merge pull request symbol#172 from rg911/task/g95_merge_library_trans…
e037fb6 
…action_builder

4 - Issue: symbol#95 Merge library transaction builder
@rg911
Added symbol#96
cc974df 
Merged swagger generated classes
@rg911
Updated account decrypt message parameter name.
52b15a5 
As the public account can also be sender's account
@rg911
Fixed doc
7f00e07
rg911 added 2 commits June 14, 2019 16:02
@rg911
Removed Nem2-Lib from package.json
83030ec
@rg911
Merge branch 'task/g96_merge_swagger_generated_classes' of github.com…
c1108e0 
…:rg911/nem2-sdk-typescript-javascript into task/g96_merge_swagger_generated_classes
@coveralls
Copy link

coveralls commented Jun 14, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 479

  • 4223 of 6397 (66.02%) changed or added relevant lines in 173 files are covered.
  • 5 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-18.4%) to 60.375%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/core/format/RawUInt64.ts 33 34 97.06%
src/infrastructure/Http.ts 0 1 0.0%
src/infrastructure/model/accountDTO.ts 3 4 75.0%
src/infrastructure/model/accountIds.ts 3 4 75.0%
src/infrastructure/model/accountInfoDTO.ts 3 4 75.0%
src/infrastructure/model/accountMetaDTO.ts 3 4 75.0%
src/infrastructure/model/accountNamesDTO.ts 3 4 75.0%
src/infrastructure/model/accountPropertiesDTO.ts 3 4 75.0%
src/infrastructure/model/accountPropertiesInfoDTO.ts 3 4 75.0%
src/infrastructure/model/accountPropertyDTO.ts 3 4 75.0%
Files with Coverage Reduction New Missed Lines %
src/infrastructure/MosaicHttp.ts 1 34.92%
src/infrastructure/NamespaceHttp.ts 1 18.0%
src/infrastructure/AccountHttp.ts 3 32.0%
Totals Coverage Status
Change from base Build 442: -18.4%
Covered Lines: 5790
Relevant Lines: 8276
💛 - Coveralls

evias
evias suggested changes Jun 14, 2019
View reviewed changes
Copy link
Contributor

@evias evias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are missing the DTO models under infrastructure/model ?

evias
evias suggested changes Jun 15, 2019
View reviewed changes
@rg911 rg911 deleted the task/g96_merge_swagger_generated_classes branch July 8, 2019 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@evias evias evias approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rg911 @coveralls @evias