-
Notifications
You must be signed in to change notification settings - Fork 261
Merge dev with main for release 1.8.1 #483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion-Samples - Created MoveAndResize and ReplayAnimation samples - Removed webpack warning for size limit
…eplayAnimation-Samples Revert "WIP - MoveAndResize and ReplayAnimation samples"
…or WorkbookFormattingChanged (#441) Add Dashboard object visibility samples for typescript/javascript and update formatting sample to also listen to WorkbookFormattingChanged event.
…e-1322781-replayAnimation-Samples emaust - ReplayAnimation & MoveAndResize samples (Typescript and Javascript)
…tes, Tableau Exchange, etc.
… into d45_docs_vizApiBugfix
TFSID:1362792 VizAPI custom title field; Tableau Exchange changes, misc edits
Fix audits at top level
update react-scripts and remove audit failures
Fix / update links - Found and fixed a bunch of links after running a link checker on the whole site. - Couple of minor indent adjustments
TFSID:1369666 - workbook formatting
D45 docs Release Notes for 1.8.1
switch to artifactory
Fix typo
johnDance
reviewed
Mar 2, 2022
| @@ -0,0 +1,19 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are these sample files showing up as new files?
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, because they were never pushed to main.
johnDance
previously approved these changes
Mar 2, 2022
johnDance
approved these changes
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.