Bump dependencies - #20381
Conversation
``` pnpm dlx @turbo/codemod@latest update ```
- Handles unknown at-rules correctly now - Keeps significant whitespace between at-rules - Optimizes `light-dark(red, red);` to just `red` - Improves handling `calc(infinity * 1px)` ```diff - border-radius: 3.40282e38px; + border-radius: 2147483647px; ```
``` (!) Your Vite config uses features that are unsupported by `configLoader: 'native'`, which is planned to become the default in a future major version of Vite: - ESM syntax in a file loaded as CommonJS (vitest.config.ts:1:1). Use a `.mjs` extension or set `"type": "module"` in the closest package.json Set `VITE_CONFIG_NATIVE_IGNORE_WARNING=true` to suppress this warning. ``` Since we're dealing with TypeScript here, and would like to keep it that way, these files are renamed to `mts` which is the TypeScript equivalent of `mjs`.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains; the WASI package now declares the Node versions required by its upgraded runtime dependency. Reviews (5): Last reviewed commit: "try using macOS 15" | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
WalkthroughThis change refreshes Rust, Node, workspace, and package dependency versions. It updates native package loading for platform and libc selection. It adds Vitest project configurations and test discovery rules. It updates snapshots for CSS compilation, utility migration, theme resolution, path formatting, and border-radius output. It also updates the Turborepo schema reference and ignores a generated WASI declaration file. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
vitest.config.mts (1)
6-6: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick winPreserve Vitest defaults in all three configurations.
Each custom
excludearray replaces Vitest's default exclusions. UseconfigDefaults.excludeas the base, then append the project-specific patterns. (v4.vitest.dev)
vitest.config.mts#L6-L6: preserve defaults, then add the spec-file and integration patterns.packages/@tailwindcss-browser/vitest.config.mts#L5-L5: preserve defaults, then add the spec-file pattern.packages/tailwindcss/vitest.config.mts#L10-L10: preserve defaults, then add the spec-file and integration patterns.Proposed fix
-import { defineConfig } from 'vitest/config' +import { configDefaults, defineConfig } from 'vitest/config' - exclude: ['**/*.spec.?(c|m)[jt]s?(x)', 'integrations/**/*'], + exclude: [...configDefaults.exclude, '**/*.spec.?(c|m)[jt]s?(x)', 'integrations/**/*'],
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: a9978531-4ee7-4826-aa10-a25a5a8636db
⛔ Files ignored due to path filters (2)
Cargo.lockis excluded by!**/*.lockpnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (24)
crates/node/.gitignorecrates/node/Cargo.tomlcrates/node/npm/wasm32-wasi/package.jsoncrates/node/package.jsonintegrations/vitest.config.mtspackage.jsonpackages/@tailwindcss-browser/package.jsonpackages/@tailwindcss-browser/vitest.config.mtspackages/@tailwindcss-cli/package.jsonpackages/@tailwindcss-node/package.jsonpackages/@tailwindcss-postcss/src/postcss-fix-relative-paths/index.test.tspackages/@tailwindcss-standalone/package.jsonpackages/@tailwindcss-upgrade/package.jsonpackages/@tailwindcss-upgrade/src/codemods/css/migrate-at-layer-utilities.test.tspackages/tailwindcss/package.jsonpackages/tailwindcss/src/compat/config.test.tspackages/tailwindcss/src/index.test.tspackages/tailwindcss/src/utilities.test.tspackages/tailwindcss/vitest.config.mtspatches/@parcel__watcher@2.6.0.patchpatches/lightningcss@1.33.0.patchpnpm-workspace.yamlturbo.jsonvitest.config.mts
This is still a version bump compared to what we had, but @napi-rs/cli from version 3.8.x, starts relying on `@emnapi/runtime@2.0.0-alpha.3` versions.
This is required because of our patches. If newer versions match, then the patches might not be compatible.
This is now aligned with napi ranges, aligned with Lightning CSS, and more importantly aligned with supported Node.js versions. Node 14 was last updated in 2023 and contains critical vulnerabilities. More info: https://nodejs.org/en/about/eol#eol-versions
We can safely drop this since the bumped Lightning CSS version includes this fix.
There was a problem hiding this comment.
Renames to fix Vitest warnings
| // Ignore warnings about unknown at-rules. | ||
| // | ||
| // TODO: drop `@position-try` once https://github.com/parcel-bundler/lightningcss/pull/1238 lands | ||
| if (/Unknown at rule: @position-try/.test(warning.message)) { | ||
| return false | ||
| } | ||
|
|
There was a problem hiding this comment.
Lightning CSS doesn't warn on unknown at-rules anymore, so we can drop this.
| " | ||
| :root, :host { | ||
| --color-what: light-dark(red, red); | ||
| --color-what: red; |
There was a problem hiding this comment.
These changes are introduced by improvements in Lightning CSS
| } | ||
| ` | ||
|
|
||
| // TODO: once Lightning CSS properly supports it, then we can drop this section: |
There was a problem hiding this comment.
More cleanup because of Lightning CSS improvements
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "$schema": "https://turbo.build/schema.json", | |||
| "$schema": "https://v2-10-8.turborepo.dev/schema.json", | |||
There was a problem hiding this comment.
The turbo codemod updated this to pin the schema
1 participant
This PR bumps dependencies and dev dependencies and applies required changes due to version bumps.
@parcel/watcherrelated dependencies to thepnpm-workflow.yamlcatalogTest plan
All tests should still pass on all platforms [ci-all]