Migrate holocene modal to runes syntax - #3759
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
tegan-temporal
changed the title
tegan-temporal
changed the title
laurakwhit
approved these changes
Aug 3, 2026
laurakwhit
left a comment
laurakwhit
left a comment
Collaborator
There was a problem hiding this comment.
Some things for a potential follow-up PR but otherwise 🚀
| bind:value={reason} | ||
| /> | ||
| </div> | ||
| {#snippet titleSnippet()} |
Collaborator
There was a problem hiding this comment.
Wonder if we really need a title snippet here or if we could just pass the title copy instead.
| @@ -88,7 +88,7 @@ | |||
| loading={$actionPending} | |||
| error={$serverError} | |||
Collaborator
There was a problem hiding this comment.
We should probably make this bindable at all call sites or ensure all the parents are clearing the error on cancel so a stale error message isn't kept in the store.
Suggested change
| error={$serverError} | |
| bind:error={$serverError} |
laurakwhit
added a commit
that referenced
this pull request
Aug 5, 2026
Auto-generated version bump from 2.53.0 to 2.53.1 Specific version: 2.53.1 Changes included: - [`e3f08379`](e3f0837) Update holocene accordion-light to runes syntax (#3714) - [`2cfa9b43`](2cfa9b4) Update holocene toggle-switch to runes syntax (#3715) (#3719) - [`e884c326`](e884c32) Update holocene textarea to runes syntax (#3724) - [`bda6e133`](bda6e13) Update holocene checkbox to runes syntax (#3725) - [`11fe6ff3`](11fe6ff) Remove unused collapsible-divider component (#3726) - [`bdc0fa77`](bdc0fa7) Update holocene skeleton table to runes syntax (#3734) - [`56a34a69`](56a34a6) Update holocene accordion to runes syntax (#3736) - [`1a0b0422`](1a0b042) Remove unused banner component (#3712) - [`11da928d`](11da928) Update holocene range-input to runes syntax (#3713) - [`d73bbde9`](d73bbde) Remove deprecated api-pagination component (#3739) - [`9cb5e28a`](9cb5e28) Update holocene number-input to runes syntax (#3735) - [`e4cec29c`](e4cec29) Update holocene tabs and tab-button to runes syntax (#3737) - [`6f6f7139`](6f6f713) Update holocene drawer-content to runes syntax (#3740) - [`4f2cef58`](4f2cef5) Update holocene tooltip to runes syntax (#3743) - [`6e01537e`](6e01537) Update holocene link to runes syntax (#3741) - [`b6775092`](b677509) Update holocene orderable-list to runes syntax (#3742) - [`447fad67`](447fad6) Update holocene pagination to runes syntax (#3738) - [`359c80ba`](359c80b) fix(schedules): tolerate duplicate schedule IDs (#3751) - [`8e81a4f0`](8e81a4f) fix(workers): use default Cloud Run runner identity (#3748) - [`3b37bbe6`](3b37bbe) Enable server-scaled deployments by default (#3672) - [`d9f9a99c`](d9f9a99) feat(workers): add release stage badges to compute provider picker (#3773) - [`7e8f2830`](7e8f283) Update holocene time-picker to runes syntax (#3754) - [`053f060a`](053f060) Update holocene drawer to runes syntax (#3755) - [`9dff9c9f`](9dff9c9) fix(workers): gate deployment actions by compute config (#3779) - [`bd9b3f60`](bd9b3f6) Update holocene copyable to runes syntax (#3756) - [`46afcfff`](46afcff) Update holocene toast to runes syntax (#3753) - [`17f64bcc`](17f64bc) Update holocene orderable-list-item to runes syntax (#3758) - [`d9ab4aa7`](d9ab4aa) Migrate event-link and event-details-link to runes syntax (#3760) - [`c09f94ac`](c09f94a) Migrate start-workflow-button and workflow-detail to runes syntax (#3761) - [`7bce9c5d`](7bce9c5) Remove dead workflow-filters component (#3762) - [`30255dba`](30255db) Sweep remaining on: directives to runes event syntax (#3771) - [`ad696bcf`](ad696bc) Migrate batch-operations header to runes syntax (#3764) - [`64f7302c`](64f7302) Migrate workflow-family-node-tree to runes syntax (#3765) - [`dc56c890`](dc56c89) Migrate start-workflow and workflow-query pages to runes syntax (#3768) - [`f989d43a`](f989d43) Migrate payload-input-with-encoding to runes syntax (#3763) - [`b19c43a0`](b19c43a) Migrate paginated-table cluster to runes syntax (#3750) - [`84414160`](8441416) Update holocene zoom-svg to runes syntax (#3757) - [`8c245928`](8c24592) Migrate holocene modal to runes syntax (#3759) - [`ef33b255`](ef33b25) Upgrade to Storybook 10 and migrate stories to defineMeta (#3772) - [`d8af57d8`](d8af57d) Enable runes mode by default (#3770) - [`1923c928`](1923c92) Use WorkflowTaskFailedCause enum (#3775) - [`b4a272ee`](b4a272e) Track pointerDown and ignore subsequent click (#3776) - [`96a06250`](96a0625) Pluralize batch operation execution type (#3784) - [`ee4652ac`](ee4652a) Resolve deployment compute config from routed version summaries (#3789) - [`7b614625`](7b61462) Standalone Activity fixes (#3788) Co-authored-by: laurakwhit <15069288+laurakwhit@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates
modal.svelteto Svelte 5 runes, in place, with all 38 ui consumers updated in the same PR.export let→$props();createEventDispatchercancelModal/confirmModal→onCancelModal/onConfirmModalcallback props.slot="title"→titleSnippet(renamed to avoid theHTMLAttributes.titlecollision),slot="content"→content,slot="footer"→footer.open/errorare$bindable;...restforwards remaining attributes to the<dialog>;toggleModalis now internal (had no external consumers).Two consumers needed judgment:
view-modal.sveltedrops the now-unusedeventarg on its confirm handler (the form handler already callspreventDefault), andramp-unversioned-modal.svelte's footer snippet renders an empty<div>whenonRemoveis falsy to keep the legacy spacer's right-alignment.Breaking change to the published
modalAPI — paired cloud-ui PR migrates its consumers: temporalio/cloud-ui#3046