Skip to content

Update dependency versions#294

Merged
mumichae merged 2 commits into
mainfrom
loosen_dep
Mar 21, 2022
Merged

Update dependency versions#294
mumichae merged 2 commits into
mainfrom
loosen_dep

Conversation

@mumichae

@mumichae mumichae commented Mar 7, 2022

Copy link
Copy Markdown
Collaborator

Remove version pins for numpy and h5py as requested in #283

@mumichae

mumichae commented Mar 7, 2022

Copy link
Copy Markdown
Collaborator Author

For some reason Github actions is returning NMI scores slightly larger than 1 during testing. I couldn't reproduce this error offline.

    def test_nmi_trivial(adata):
        score = scib.me.nmi(adata, 'celltype', 'celltype')
>       assert score == 1
E       assert 1.0000000000000002 == 1
E         +1.0000000000000002
E         -1

@mumichae
mumichae requested a review from LuckyMD March 7, 2022 13:13
@Zethson

Zethson commented Mar 10, 2022

Copy link
Copy Markdown
Member

Great, thank you! We'd also require a swift PyPI release after this PR is merged.

@mumichae
mumichae merged commit c4ce6d1 into main Mar 21, 2022
@mumichae
mumichae deleted the loosen_dep branch March 21, 2022 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants