add case_weights argument to workflow_set - #82
Conversation
probably more informative to refer to the engine rather than model spec in the warning. also, ignores the case weights entirely if they aren't implemented for one model: not sure whether ignoring entirely or just for some models is more sound.
|
cc @DavisVaughan—if you're game, let's review this PR in pairing on Monday. Would like to watch your process and also get a sense for whether there's a better way to subset into these objects in the case weights logic. I think some of the code points toward need for getters/indicators like |
rather than ignoring case weights entirely if any of the models can't use them.
DavisVaughan
left a comment
There was a problem hiding this comment.
Partial review which we will continue on Tuesday
DavisVaughan
left a comment
There was a problem hiding this comment.
Looks good with a few comments
in response to davis' review. also, makes tests more modular, updates snapshots, makes better use of rlang machinery, uses tidy style for function names.
|
Much appreciated, @DavisVaughan! Rest of changes resolved in 639c2ea. |
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Created on 2022-05-26 by the reprex package (v2.0.1)