Simplify test setup#2420
Conversation
8ad57d0 to
628e9c4
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2420 +/- ##
=======================================
Coverage 91.23% 91.23%
=======================================
Files 20 20
Lines 11831 11831
Branches 2296 2296
=======================================
Hits 10794 10794
Misses 568 568
Partials 469 469
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
13a6fdb to
a4b7cd6
Compare
|
Note we should be able to get rid of MSP_CONDA_PREFIX etc from setup.py now too, given this? |
I'm not sure - isn't this used in the feedstock? |
a4b7cd6 to
4871c43
Compare
|
Oh yes, maybe it is! Oops. |
efe0a6f to
776637a
Compare
bef78c9 to
261de5e
Compare
eff37bf to
99c1809
Compare
99c1809 to
3eb78d2
Compare
|
Some gnarly powershell needed here - what's the basic gist of what's going on there? Is it a problem with the wheel or the locally build dll? If it's the wheel, does this need to be done for the pypi artefact also? |
The basic problem is that building then running the tests was not finding the needed DLLs. I tried putting what was needed on the |
|
Might be worth writing some of this up if it's going to stay long term - won't be obvious to most devs |
No description provided.