Skip to content

Simplify test setup#2420

Merged
benjeffery merged 1 commit into
tskit-dev:mainfrom
benjeffery:no-conda
Sep 12, 2025
Merged

Simplify test setup#2420
benjeffery merged 1 commit into
tskit-dev:mainfrom
benjeffery:no-conda

Conversation

@benjeffery
Copy link
Copy Markdown
Member

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.23%. Comparing base (a4d801c) to head (3eb78d2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2420   +/-   ##
=======================================
  Coverage   91.23%   91.23%           
=======================================
  Files          20       20           
  Lines       11831    11831           
  Branches     2296     2296           
=======================================
  Hits        10794    10794           
  Misses        568      568           
  Partials      469      469           
Flag Coverage Δ
C 91.23% <ø> (ø)
python 98.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@benjeffery benjeffery force-pushed the no-conda branch 2 times, most recently from 13a6fdb to a4b7cd6 Compare September 11, 2025 12:26
@jeromekelleher
Copy link
Copy Markdown
Member

Note we should be able to get rid of MSP_CONDA_PREFIX etc from setup.py now too, given this?

@benjeffery
Copy link
Copy Markdown
Member Author

MSP_CONDA_PREFIX

I'm not sure - isn't this used in the feedstock?

@jeromekelleher
Copy link
Copy Markdown
Member

Oh yes, maybe it is! Oops.

@benjeffery benjeffery force-pushed the no-conda branch 10 times, most recently from efe0a6f to 776637a Compare September 11, 2025 19:09
@benjeffery benjeffery force-pushed the no-conda branch 11 times, most recently from bef78c9 to 261de5e Compare September 11, 2025 22:43
@benjeffery benjeffery force-pushed the no-conda branch 14 times, most recently from eff37bf to 99c1809 Compare September 12, 2025 00:43
@benjeffery benjeffery merged commit 76ea04a into tskit-dev:main Sep 12, 2025
8 of 9 checks passed
@benjeffery benjeffery deleted the no-conda branch September 12, 2025 00:53
@jeromekelleher
Copy link
Copy Markdown
Member

Some gnarly powershell needed here - what's the basic gist of what's going on there? Is it a problem with the wheel or the locally build dll? If it's the wheel, does this need to be done for the pypi artefact also?

@benjeffery
Copy link
Copy Markdown
Member Author

Some gnarly powershell needed here

The basic problem is that building then running the tests was not finding the needed DLLs. I tried putting what was needed on the PATH but had no success. Building the wheel is a workaround as delvewheel finds the DLLs and puts them in the wheel. We then run the tests with the wheel.

@jeromekelleher
Copy link
Copy Markdown
Member

Might be worth writing some of this up if it's going to stay long term - won't be obvious to most devs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants