Skip to content

Conversation

@jeromekelleher
Copy link
Member

Second attempt at simplifying C dependencies after #1958.

Closes #1687

@codecov
Copy link

codecov bot commented Dec 1, 2021

Codecov Report

Merging #1973 (5661389) into main (b726017) will decrease coverage by 1.71%.
The diff coverage is n/a.

❗ Current head 5661389 differs from pull request most recent head 27a334c. Consider uploading reports for the commit 27a334c to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1973      +/-   ##
==========================================
- Coverage   93.32%   91.60%   -1.72%     
==========================================
  Files          27       27              
  Lines       25212    26028     +816     
  Branches     1108     1342     +234     
==========================================
+ Hits        23530    23844     +314     
- Misses       1648     2133     +485     
- Partials       34       51      +17     
Flag Coverage Δ
c-tests 92.32% <ø> (ø)
lwt-tests 89.14% <ø> (ø)
python-c-tests 71.68% <ø> (ø)
python-tests 98.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/tskit/trees.py 78.02% <0.00%> (-19.78%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2ca0ba...27a334c. Read the comment docs.

@jeromekelleher
Copy link
Member Author

I think this is ready to go - there will be some short-term pain for devs though as git gets confused about having/not having submodules.

Copy link
Member

@benjeffery benjeffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well here and seems that meson dist also works. I added a changelog.

@jeromekelleher
Copy link
Member Author

Great! Let's merge, no point in putting this one off.

@mergify mergify bot merged commit 8dd996d into tskit-dev:main Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove tree diff iterator removal?

2 participants