-
Notifications
You must be signed in to change notification settings - Fork 78
Rejiggle c deps #1958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rejiggle c deps #1958
Conversation
05bf57e to
f93a761
Compare
3edb6fc to
eafbd02
Compare
eafbd02 to
a087bf6
Compare
|
The short answer is that I'd need to dig in a bit in order to know. Right now, I manually copy files over, but I'd prefer using a submodule. The submodule approach currently fails because the build system sees more than one symlink to the same file. |
This should help with that hopefully as there's now there's a lot less symlinking, and none under the |
That should work. I'll just have to have a way to remember to update both of them as necessary. |
|
I assume this would be superseded by #1967 ? |
|
Yes - I'll update when I get a chance |
|
Actually easier to start again, closing. |
This changes around the repo layout a little to reduce the amount of symlinking we're doing. It's mainly motivated by the need to move away from the current approach so that we can work with versions of meson > 0.55, which we've been pinning on for a while an has been cropping up as a problem with devs on a regular basis.
The upside is that meson works much better using it's native subproject mechanism, and I think the overall project structure is a bit less complicated.
The downside is that we have two different ways of specifying the kastore dependency for C library development and the Python module, which will both have to be updated when we do a version bump. We'll need to document this clearly. (For example, I've forgotten to update the submodule to kastore C_2.0.1). I guess the best thing to do is put in a few tests that check the version number in various places to make it harder to forget this.
Any thoughts? @molpopgen, how does this affect you for the downstream Rust lib?