Skip to content

Conversation

@jeromekelleher
Copy link
Member

@jeromekelleher jeromekelleher commented May 17, 2022

Add Mutation.edge attribute

#685

@jeromekelleher jeromekelleher marked this pull request as draft May 17, 2022 19:05
@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #2279 (afd19b2) into main (9968e62) will increase coverage by 0.03%.
The diff coverage is 97.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2279      +/-   ##
==========================================
+ Coverage   93.30%   93.33%   +0.03%     
==========================================
  Files          27       27              
  Lines       26097    26134      +37     
  Branches     1175     1175              
==========================================
+ Hits        24349    24393      +44     
+ Misses       1718     1711       -7     
  Partials       30       30              
Flag Coverage Δ
c-tests 92.31% <100.00%> (+0.08%) ⬆️
lwt-tests 89.05% <ø> (ø)
python-c-tests 71.88% <93.75%> (+0.01%) ⬆️
python-tests 98.88% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/_tskitmodule.c 90.90% <92.30%> (-0.01%) ⬇️
c/tskit/tables.c 90.28% <100.00%> (+<0.01%) ⬆️
c/tskit/trees.c 95.29% <100.00%> (+0.29%) ⬆️
python/tskit/trees.py 98.05% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9968e62...afd19b2. Read the comment docs.

@jeromekelleher jeromekelleher force-pushed the edge-mutations branch 2 times, most recently from 4384fb0 to 7239339 Compare May 18, 2022 13:58
@jeromekelleher jeromekelleher requested a review from benjeffery May 18, 2022 13:58
@jeromekelleher jeromekelleher marked this pull request as ready for review May 18, 2022 13:59
@jeromekelleher jeromekelleher mentioned this pull request May 18, 2022
@jeromekelleher
Copy link
Member Author

Bumping this, can I get a review please @benjeffery?

Copy link
Member

@benjeffery benjeffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think the tables API always having an empty edge might be a bot of a gotcha, but I think it makes sense to do this.

@mergify mergify bot merged commit 6736cef into tskit-dev:main May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants