c level edge id array #2340
Merged
c level edge id array #2340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2340 +/- ##
=======================================
Coverage 93.29% 93.30%
=======================================
Files 28 28
Lines 26789 26797 +8
Branches 1233 1233
=======================================
+ Hits 24994 25002 +8
Misses 1762 1762
Partials 33 33
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
benjeffery
approved these changes
Jun 16, 2022
Member
benjeffery
left a comment
benjeffery
left a comment
There was a problem hiding this comment.
LGTM! One reword of the docs.
c/tskit/trees.h
Outdated
Comment on lines
180
to
182
| @brief The edge encoding the relationship between u and its parent is | ||
| edge[u]. Equal to``TSK_NULL`` if node u is a root or is not a node in | ||
| the current tree. |
Member
There was a problem hiding this comment.
Suggested change
| @brief The edge encoding the relationship between u and its parent is | |
| edge[u]. Equal to``TSK_NULL`` if node u is a root or is not a node in | |
| the current tree. | |
| @brief Array of edge ids where ``edge[u]`` is the edge that encodes the relationship between child node ``u`` and its | |
| parent. Equal to``TSK_NULL`` if node ``u`` is a root, virtual root or is not a node in the current tree. |
jeromekelleher
approved these changes
Jun 16, 2022
Member
jeromekelleher
left a comment
jeromekelleher
left a comment
There was a problem hiding this comment.
Great work, thanks @GertjanBisschop!
GertjanBisschop
force-pushed
the
add_edge_array
branch
3 times, most recently
from
f87107b to
498c0d9
Compare
Member
|
@Mergifyio refresh |
Contributor
✅ Pull request refreshed |
Member
|
Circle CI AWOL again.... |
Member
|
@Mergifyio rebase |
Contributor
✅ Branch has been successfully rebased |
benjeffery
force-pushed
the
add_edge_array
branch
from
498c0d9 to
c8eb484
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First pass at the C level edge array (#2304).