Skip to content

Conversation

@jeremyguez
Copy link
Contributor

Here is the new PR for the B2 index.
@jeromekelleher

@jeremyguez jeremyguez mentioned this pull request Jun 20, 2022
@codecov
Copy link

codecov bot commented Jun 20, 2022

Codecov Report

Merging #2353 (9279607) into main (22d4a50) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2353   +/-   ##
=======================================
  Coverage   93.29%   93.29%           
=======================================
  Files          28       28           
  Lines       26768    26781   +13     
  Branches     1228     1232    +4     
=======================================
+ Hits        24973    24986   +13     
  Misses       1762     1762           
  Partials       33       33           
Flag Coverage Δ
c-tests 92.24% <ø> (ø)
lwt-tests 89.05% <ø> (ø)
python-c-tests 71.15% <7.69%> (-0.06%) ⬇️
python-tests 98.86% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/tskit/trees.py 98.34% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22d4a50...9279607. Read the comment docs.

@benjeffery
Copy link
Member

It's no biggie so no worries but as a quick tip - you can force-push anything to an existing PR, so there's usually no need to make a new one.

git checkout -b fix_pr_branch
.... fix things ....
git checkout original_broken_branch
git reset --hard fix_pr_branch
git push -f repo_name original_broken_branch

@mergify mergify bot merged commit 5e38698 into tskit-dev:main Jun 21, 2022
@jeremyguez
Copy link
Contributor Author

Thank you @benjeffery for the tip, very useful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants