Edge array Python API #2357
Edge array Python API #2357
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2357 +/- ##
==========================================
- Coverage 93.28% 93.25% -0.03%
==========================================
Files 28 28
Lines 26840 26863 +23
Branches 1229 1229
==========================================
+ Hits 25038 25052 +14
- Misses 1769 1778 +9
Partials 33 33
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
We should probably get this in for 0.5.0 @benjeffery, since the low-level changes are done already? |
python/tests/test_highlevel.py
Outdated
| for ts in get_example_tree_sequences(): | ||
| edge_visited = np.zeros(ts.num_edges, dtype=bool) | ||
| for mapping, tree in zip(ts._tree_node_edges(), ts.trees()): | ||
| # for mapping, tree in zip(ts._tree_node_edges(), ts.trees()): |
There was a problem hiding this comment.
I guess we can delete the _tree_node_edges thing now as well (not sure where that's come from?)
There was a problem hiding this comment.
In general we don't want to keep commented out bits lying around -that's what git is for!
benjeffery
left a comment
benjeffery
left a comment
There was a problem hiding this comment.
LGTM, one question about the change log.
GertjanBisschop
force-pushed
the
add_edge_array_python
branch
from
3d1d281 to
6982204
Compare
|
Resolves #2361 |
|
|
|
CircleCI still AWOL. |
benjeffery
force-pushed
the
add_edge_array_python
branch
from
6982204 to
428768f
Compare
|
@Mergifyio refresh |
✅ Pull request refreshed |
benjeffery
force-pushed
the
add_edge_array_python
branch
from
428768f to
8e92e5a
Compare
3 participants
First pass at low-level Python and Python API for
Tree.edge_array.