Copy samples when copying a variant to fix segfault when copy.samples is accessed

[benjeffery]

Fixes #2400

[benjeffery]

@petrelharp or @molpopgen Are you able to do a quick review here? I want to get out a point release ASAP to fix this.

[molpopgen]

I can take a peek later today!

[codecov]

Codecov Report

Merging #2401 (e2ec4d0) into main (dc45651) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2401   +/-   ##
=======================================
  Coverage   93.33%   93.34%           
=======================================
  Files          28       28           
  Lines       26977    26982    +5     
  Branches     1245     1245           
=======================================
+ Hits        25180    25187    +7     
+ Misses       1763     1761    -2     
  Partials       34       34           

Flag	Coverage Δ
c-tests	92.26% <100.00%> (+<0.01%)	⬆️
lwt-tests	89.05% <ø> (ø)
python-c-tests	71.01% <ø> (+0.01%)	⬆️
python-tests	98.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
c/tskit/genotypes.c	90.29% <100.00%> (+0.11%)	⬆️
python/_tskitmodule.c	90.66% <0.00%> (+0.03%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc45651...e2ec4d0. Read the comment docs.

[molpopgen]

I don't see any obvious red flags in the changes to the C side. But I may not be the best person to find them.

I ran this, which didn't flag anything relevant to these diffs:

find tskit -name '*.c' | xargs clang-tidy -p build/compile_commands.json --checks="all"

[benjeffery]

Thanks @molpopgen!

[benjeffery]

@Mergifyio rebase

[mergify]

rebase

✅ Branch has been successfully rebased

[benjeffery]

Merging without an approval as @jeromekelleher is away and we need to push out a fix.