-
Notifications
You must be signed in to change notification settings - Fork 78
Add tree sequence metadata and metadata_schema to C API #642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3ddec5e to
76a2117
Compare
328791d to
16efd3b
Compare
Codecov Report
@@ Coverage Diff @@
## master #642 +/- ##
==========================================
- Coverage 87.71% 87.62% -0.09%
==========================================
Files 23 23
Lines 17360 17426 +66
Branches 3421 3432 +11
==========================================
+ Hits 15227 15270 +43
- Misses 1044 1058 +14
- Partials 1089 1098 +9
Continue to review full report at Codecov.
|
|
Looks like I could get a little more coverage here, setting back to draft. |
7c8f775 to
4235fbe
Compare
|
@jeromekelleher Added a test on the TS methods. Looks like the rest of the coverage misses are hard error paths. Ready for review. |
jeromekelleher
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @benjeffery. I'll update to fix a couple of small issues and tag for merging.
4235fbe to
7452c1e
Compare
|
@jeromekelleher did you see my comment above about the casting to |
|
Oops just seen the reply, ignore! |
|
I seem to have messed the PR up here - I thought you were off today @benjeffery so I force pushed a couple of changes. Looks like I broke stuff. Crap, I think I pulled in kastore updates by |
|
I made the mess, I'll fix it up! |
|
I'm off, but can quickly push the branch back to how it was? |
Na, thanks, it's an easy fix. |
7452c1e to
3673e8f
Compare
3673e8f to
8a49681
Compare
C API part of #534. Adds
metadataandmetadata_schemafields to table collection, with accessors on tree sequence. These store arbitrary bytes and are optional in the file format.