Skip to content

Conversation

@benjeffery
Copy link
Member

@benjeffery benjeffery commented May 25, 2020

Low-level python part of #534, stacked on #642

  • TableCollection properties
  • TreeSequence properties

@benjeffery benjeffery changed the title Top level metadata - low-level python Add tree sequence metadata and schema to low-level python May 25, 2020
@benjeffery benjeffery force-pushed the top-level-metadata-python branch from 282aa1d to e78151d Compare May 25, 2020 01:17
@codecov
Copy link

codecov bot commented May 25, 2020

Codecov Report

Merging #644 into master will decrease coverage by 0.02%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #644      +/-   ##
==========================================
- Coverage   87.65%   87.63%   -0.03%     
==========================================
  Files          23       23              
  Lines       17503    17523      +20     
  Branches     3451     3450       -1     
==========================================
+ Hits        15343    15357      +14     
- Misses       1058     1062       +4     
- Partials     1102     1104       +2     
Flag Coverage Δ
#c_tests 88.89% <ø> (ø)
#python_c_tests 91.05% <87.50%> (-0.06%) ⬇️
#python_tests 98.95% <ø> (ø)
Impacted Files Coverage Δ
python/_tskitmodule.c 83.83% <87.50%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0280623...a042938. Read the comment docs.

Copy link
Member

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think we could take the opportunity to refactor a little bit to reduce duplication in the metadata/schema set/get code paths.

@benjeffery benjeffery force-pushed the top-level-metadata-python branch 2 times, most recently from 6bc0de5 to aff1986 Compare June 1, 2020 13:39
@benjeffery benjeffery marked this pull request as ready for review June 1, 2020 13:41
@benjeffery
Copy link
Member Author

@jeromekelleher Ready for review

(env) benj@treebeard:~/projects/tskit/python$ python stress_lowlevel.py -m lowlevel
iter	tests	err	fail	skip	RSS	min	max	max@iter
309	174	0	0	0	80320	79976	80320	1

Copy link
Member

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - small formatting problem.

@benjeffery
Copy link
Member Author

@mergify refresh

@mergify
Copy link
Contributor

mergify bot commented Jun 1, 2020

Command refresh: success

Hey, I reacted but my real name is @Mergifyio

@benjeffery
Copy link
Member Author

travis is AWOL, attempting to kick it into gear

@benjeffery benjeffery force-pushed the top-level-metadata-python branch from 24def10 to a042938 Compare June 1, 2020 17:41
@mergify mergify bot merged commit dc197b6 into tskit-dev:master Jun 1, 2020
@benjeffery benjeffery deleted the top-level-metadata-python branch June 1, 2020 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants