-
Notifications
You must be signed in to change notification settings - Fork 78
Add tree sequence metadata and schema to low-level python #644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
282aa1d to
e78151d
Compare
Codecov Report
@@ Coverage Diff @@
## master #644 +/- ##
==========================================
- Coverage 87.65% 87.63% -0.03%
==========================================
Files 23 23
Lines 17503 17523 +20
Branches 3451 3450 -1
==========================================
+ Hits 15343 15357 +14
- Misses 1058 1062 +4
- Partials 1102 1104 +2
Continue to review full report at Codecov.
|
jeromekelleher
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I think we could take the opportunity to refactor a little bit to reduce duplication in the metadata/schema set/get code paths.
6bc0de5 to
aff1986
Compare
|
@jeromekelleher Ready for review |
jeromekelleher
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - small formatting problem.
aff1986 to
24def10
Compare
|
@mergify refresh |
|
Command Hey, I reacted but my real name is @Mergifyio |
|
travis is AWOL, attempting to kick it into gear |
24def10 to
a042938
Compare
Low-level python part of #534, stacked on #642