-
Notifications
You must be signed in to change notification settings - Fork 78
Add high-level python API for tree-sequence metadata #666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #666 +/- ##
==========================================
+ Coverage 87.74% 87.75% +0.01%
==========================================
Files 23 23
Lines 17668 17687 +19
Branches 3498 3498
==========================================
+ Hits 15503 15522 +19
Misses 1062 1062
Partials 1103 1103
Continue to review full report at Codecov.
|
jeromekelleher
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, minor comments.
python/tests/test_tables.py
Outdated
| ) | ||
|
|
||
| def metadata_example_data(self): | ||
| try: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like this as it makes the tests stateful and the test data will depend on what other tests are run on this class. Also adding instance variables to a TestCase is a bit weird. Either put in some constants, or make val a parameter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made it a param.
8eab997 to
606a1df
Compare
|
@jeromekelleher Fixed up - given the number of this PR I got off lightly. 👿 |
|
Not an Iron Maiden fan then? I keep singing "6,66 the PR of the Beast" to myself. Classic. |
606a1df to
9ebce17
Compare
9ebce17 to
4e395bd
Compare
4e395bd to
579299d
Compare
579299d to
f96a4db
Compare
|
Travis AWOL again - will look into this as happening a lot. |
Resolves #534
As we are doing a metadata docs pass in #603 I have only done minimal docs.