C_0.99.10 release prep #1133
Merged
C_0.99.10 release prep #1133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjeffery
force-pushed
the
C_0.99.10-release-prep
branch
2 times, most recently
from
ffa6562 to
cde68d9
Compare
Codecov Report
@@ Coverage Diff @@
## main #1133 +/- ##
=======================================
Coverage 93.71% 93.71%
=======================================
Files 26 26
Lines 21081 21081
Branches 899 899
=======================================
Hits 19756 19756
Misses 1288 1288
Partials 37 37
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
jeromekelleher
approved these changes
Jan 25, 2021
Member
jeromekelleher
left a comment
jeromekelleher
left a comment
There was a problem hiding this comment.
LGTM, but I think we shouldn't document the actual change since it's an internal thing (which SLiM shouldn't be using, in an ideal world).
benjeffery
force-pushed
the
C_0.99.10-release-prep
branch
from
cde68d9 to
97a57e7
Compare
benjeffery
force-pushed
the
C_0.99.10-release-prep
branch
from
97a57e7 to
f6b5d34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.