Skip to content

Conversation

@benjeffery
Copy link
Member

Fixes #1956

@benjeffery benjeffery force-pushed the simple_schema branch 2 times, most recently from a989287 to 175e6ef Compare November 30, 2021 14:46
@codecov
Copy link

codecov bot commented Nov 30, 2021

Codecov Report

Merging #1972 (186bc77) into main (344326c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1972   +/-   ##
=======================================
  Coverage   93.36%   93.36%           
=======================================
  Files          27       27           
  Lines       25557    25557           
  Branches     1114     1114           
=======================================
  Hits        23861    23861           
  Misses       1660     1660           
  Partials       36       36           
Flag Coverage Δ
c-tests 92.38% <ø> (ø)
lwt-tests 89.05% <ø> (ø)
python-c-tests 72.12% <ø> (ø)
python-tests 98.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/tskit/metadata.py 99.01% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 344326c...186bc77. Read the comment docs.

@jeromekelleher
Copy link
Member

In #1944 I added MetadataSchema.permissive_json()`` as a class method that returned this instance - what do you think of that?

@benjeffery
Copy link
Member Author

In #1944 I added MetadataSchema.permissive_json()`` as a class method that returned this instance - what do you think of that?

Ah, hadn't gone closely through that PR yet - Seems a more organised place to put it.

@jeromekelleher
Copy link
Member

Nice to get this documented for 0.4.0 @benjeffery?

@benjeffery benjeffery force-pushed the simple_schema branch 2 times, most recently from 5697fcf to aefd438 Compare December 10, 2021 11:29
@benjeffery
Copy link
Member Author

@jeromekelleher Fixed up!

Copy link
Member

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 958a117 into tskit-dev:main Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Easy way to make a metadata schema

2 participants