-
Notifications
You must be signed in to change notification settings - Fork 78
Variant copy for lowlevel python #2169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Note to self - run the stress test for leaks. |
Codecov Report
@@ Coverage Diff @@
## main #2169 +/- ##
==========================================
- Coverage 93.29% 93.28% -0.02%
==========================================
Files 27 27
Lines 26039 26059 +20
Branches 1163 1163
==========================================
+ Hits 24294 24308 +14
- Misses 1715 1721 +6
Partials 30 30
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Looks like the linter has broken deps, will investigate. |
|
@Mergifyio rebase |
❌ Base branch update has failedGit reported the following error: err-code: F4A65 |
|
I can take a look at this once it's rebased @benjeffery |
cd42909 to
4bb7f39
Compare
|
Looks right to me, but I'd run some serious stress tests on this sort of thing to reassure myself as it's very subtle. |
db3eb8f to
6f35de2
Compare
Stress test is fine, max iter is at 100 after 1000 runs. I've also gone over the code again to try and satisfy myself. |
6f35de2 to
a2c01fa
Compare
|
I'd usually run in a loop in a standalone script as well, as the stress script is quite slow and noisy when checking specific changes like this. Problems usually show up very quickly. |
|
I modified the stress script to only run the |
Stacked on #2157
Adds
restricted_copyto the low-level python. I think I've covered all the lifecycle stuff here, but a close review would be appriciated.