Skip to content

Conversation

@jeromekelleher
Copy link
Member

Not for merging

@codecov
Copy link

codecov bot commented Sep 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.71%. Comparing base (4187575) to head (4c892d7).
⚠️ Report is 76 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3279      +/-   ##
==========================================
+ Coverage   89.60%   89.71%   +0.11%     
==========================================
  Files          28       29       +1     
  Lines       31895    32332     +437     
  Branches     5857     5925      +68     
==========================================
+ Hits        28579    29008     +429     
- Misses       1886     1888       +2     
- Partials     1430     1436       +6     
Flag Coverage Δ
c-tests 86.66% <100.00%> (+<0.01%) ⬆️
lwt-tests 80.38% <ø> (ø)
python-c-tests 88.18% <ø> (ø)
python-tests 98.80% <ø> (-0.05%) ⬇️
python-tests-no-jit 32.94% <ø> (?)
python-tests-numpy1 50.56% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
c/tskit/trees.c 90.62% <100.00%> (+<0.01%) ⬆️

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@benjeffery
Copy link
Member

Post 1.0 are we ok with the ABI break this makes? I think so as we state in the docs:

"We do not currently make any guarantees about ABI stability, since the primary use-case is for tskit to be embedded within another application rather than used as a shared library. If you do intend to use tskit as a shared library and ABI stability is therefore important to you, please let us know and we can plan accordingly."

@jeromekelleher
Copy link
Member Author

I agree - strong API guarantees are enough, and we just highlight clearly that this is an ABI breaking release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants