-
Notifications
You must be signed in to change notification settings - Fork 79
Tolerate invalid parents when computing mutation parents #3309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tolerate invalid parents when computing mutation parents #3309
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3309 +/- ##
==========================================
- Coverage 89.80% 89.80% -0.01%
==========================================
Files 29 29
Lines 31026 31043 +17
Branches 5679 5682 +3
==========================================
+ Hits 27863 27877 +14
- Misses 1777 1779 +2
- Partials 1386 1387 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
91a851b to
ccc7d08
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it. Just needs a few more tests.
| tables.mutations.parent[:] = 42 | ||
| tables.compute_mutation_parents() | ||
| assert tables.mutations.parent[0] == tskit.NULL | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another test checking the parent data is preserved on error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if possible we should check the data is preserved on error even if TSK_NO_CHECK_INTEGRITY is on
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
11aa116 to
17f8200
Compare
17f8200 to
5e809c0
Compare
Fixes #3303