Skip to content

Conversation

@benjeffery
Copy link
Member

Fixes #634

@benjeffery benjeffery requested a review from jeromekelleher May 23, 2020 00:43
@codecov
Copy link

codecov bot commented May 23, 2020

Codecov Report

Merging #639 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #639   +/-   ##
=======================================
  Coverage   87.42%   87.42%           
=======================================
  Files          22       22           
  Lines       16911    16912    +1     
  Branches     3316     3316           
=======================================
+ Hits        14785    14786    +1     
  Misses       1040     1040           
  Partials     1086     1086           
Flag Coverage Δ
#c_tests 88.64% <100.00%> (+<0.01%) ⬆️
#python_c_tests 90.66% <100.00%> (+<0.01%) ⬆️
#python_tests 98.96% <100.00%> (+<0.01%) ⬆️
Impacted Files Coverage Δ
python/tskit/metadata.py 98.33% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c31e974...833a9e4. Read the comment docs.

Copy link
Member

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think we should remove the top-level "SLiM" key in the metadata. Examples are sticky and I don't think this is what we'd encourage as best-practise.

@benjeffery benjeffery force-pushed the metadata-top-level-object branch from db75f15 to 6ba86cd Compare May 24, 2020 15:39
@benjeffery benjeffery force-pushed the metadata-top-level-object branch from 6ba86cd to 833a9e4 Compare May 24, 2020 16:01
@mergify mergify bot merged commit 42715a8 into tskit-dev:master May 24, 2020
@benjeffery benjeffery deleted the metadata-top-level-object branch May 30, 2020 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enforce that metadata is an object at top level

2 participants