Skip to content

Conversation

@jeromekelleher
Copy link
Member

Depends on #709 - diff will be easier to read when it's merged.

@jeromekelleher jeromekelleher requested a review from benjeffery July 9, 2020 13:44
@codecov
Copy link

codecov bot commented Jul 9, 2020

Codecov Report

Merging #713 into master will increase coverage by 2.30%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #713      +/-   ##
==========================================
+ Coverage   85.43%   87.74%   +2.30%     
==========================================
  Files           8       24      +16     
  Lines        9615    19109    +9494     
  Branches     1837     3563    +1726     
==========================================
+ Hits         8215    16768    +8553     
- Misses        799     1273     +474     
- Partials      601     1068     +467     
Flag Coverage Δ
#c_tests 85.44% <100.00%> (+<0.01%) ⬆️
#python_c_tests 90.08% <ø> (?)
#python_tests 99.00% <ø> (?)
Impacted Files Coverage Δ
c/tskit/tables.c 81.39% <100.00%> (+0.01%) ⬆️
c/tskit/core.h 100.00% <0.00%> (ø)
python/tskit/formats.py 100.00% <0.00%> (ø)
python/tskit/trees.py 98.24% <0.00%> (ø)
python/tskit/tables.py 99.68% <0.00%> (ø)
python/tskit/exceptions.py 100.00% <0.00%> (ø)
python/tskit/__init__.py 100.00% <0.00%> (ø)
python/tskit/__main__.py 0.00% <0.00%> (ø)
python/tskit/vcf.py 100.00% <0.00%> (ø)
python/tskit/_version.py 100.00% <0.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0268fa7...8eba3de. Read the comment docs.

@jeromekelleher jeromekelleher force-pushed the index-lifecycle-docs branch from 1de13e5 to cef5234 Compare July 9, 2020 15:29
@jeromekelleher
Copy link
Member Author

This is a fairly straightforward improvement, so I'm going to merge.

@jeromekelleher jeromekelleher merged commit 27c9417 into tskit-dev:master Jul 15, 2020
@jeromekelleher jeromekelleher deleted the index-lifecycle-docs branch July 15, 2020 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant