Add an example of dynamically showing labels#225
Merged
jeromekelleher merged 1 commit intotskit-dev:mainfrom Jan 30, 2023
Merged
Add an example of dynamically showing labels#225jeromekelleher merged 1 commit intotskit-dev:mainfrom
jeromekelleher merged 1 commit intotskit-dev:mainfrom
Conversation
jeromekelleher
approved these changes
Jan 30, 2023
Member
jeromekelleher
left a comment
jeromekelleher
left a comment
There was a problem hiding this comment.
LGTM - but suggest avoiding the packset metadata stuff, it's not sufficiently different in terms of performance to warrant the complexity.
benjeffery
approved these changes
Jan 30, 2023
Member
benjeffery
left a comment
benjeffery
left a comment
There was a problem hiding this comment.
LGTM - agree with JK on the metadata though.
This can be really useful for large trees
Member
Author
|
Done, ready to merge. Thanks for the comments, both: this is a nice capability to document. |
Contributor
|
This is awesome. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This can be really useful for large trees