Update adapt vs ref24 cost script for current APIs - #479
Open
ss2098 wants to merge 1 commit into
Open
Conversation
lmoresi
requested changes
Aug 2, 2026
lmoresi
left a comment
Member
There was a problem hiding this comment.
Adversarial review
Same three findings as #476, and they bite harder here:
- MAJOR — free-slip → no-slip on the upper boundary (in
build()). This script's sole purpose is a cost comparison against a stored ref-24 baseline taken under free-slip with warm starts; the comparison is invalidated, not updated. Useadd_rotated_freeslip_bc(0, "Upper"). - MAJOR —
zero_init_guess=Truein the timed loops: cold-start timings against a warm-start baseline. - MINOR —
deform()double-counts field transfer in the remap timings (it runsremesh_with_field_transferinternally).
Requested changes as on #476. The API updates themselves verified correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates scripts/adapt_vs_ref24_cost.py so the cost comparison script runs with the current Underworld3 APIs.
Changes include:
This does not change solver internals.
Validation:
Example local output: