Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add worker condition to edge compilation #3549

Merged
merged 1 commit into from Feb 1, 2023
Merged

add worker condition to edge compilation #3549

merged 1 commit into from Feb 1, 2023

Conversation

sokra
Copy link
Member

@sokra sokra commented Jan 31, 2023

some packages expect worker or browser condition to work on edge runtime

@sokra sokra requested a review from a team as a code owner January 31, 2023 16:52
@vercel
Copy link

vercel bot commented Jan 31, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 31, 2023 at 4:52PM (UTC)
9 Ignored Deployments
Name Status Preview Comments Updated
examples-basic-web ⬜️ Ignored (Inspect) Jan 31, 2023 at 4:52PM (UTC)
examples-cra-web ⬜️ Ignored (Inspect) Jan 31, 2023 at 4:52PM (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Jan 31, 2023 at 4:52PM (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Jan 31, 2023 at 4:52PM (UTC)
examples-native-web ⬜️ Ignored (Inspect) Jan 31, 2023 at 4:52PM (UTC)
examples-nonmonorepo ⬜️ Ignored (Inspect) Jan 31, 2023 at 4:52PM (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Jan 31, 2023 at 4:52PM (UTC)
examples-tailwind-web ⬜️ Ignored (Inspect) Jan 31, 2023 at 4:52PM (UTC)
examples-vite-web ⬜️ Ignored (Inspect) Jan 31, 2023 at 4:52PM (UTC)

@github-actions
Copy link
Contributor

Benchmark for 0d0acc6

Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 8149.88µs ± 62.56µs 8818.61µs ± 118.75µs +8.21% +3.70%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 8149.88µs ± 62.56µs 8818.61µs ± 118.75µs +8.21% +3.70%
bench_hmr_to_commit/Turbopack RCC/1000 modules 8655.33µs ± 170.43µs 8609.92µs ± 163.96µs -0.52%
bench_hmr_to_commit/Turbopack RSC/1000 modules 475.57ms ± 5.44ms 509.20ms ± 13.71ms +7.07%
bench_hmr_to_commit/Turbopack SSR/1000 modules 8781.04µs ± 134.47µs 8599.91µs ± 106.79µs -2.06%
bench_hmr_to_eval/Turbopack CSR/1000 modules 7400.20µs ± 215.68µs 7253.56µs ± 66.60µs -1.98%
bench_hmr_to_eval/Turbopack RCC/1000 modules 8747.81µs ± 164.97µs 8844.87µs ± 38.37µs +1.11%
bench_hmr_to_eval/Turbopack SSR/1000 modules 8693.87µs ± 83.86µs 8585.50µs ± 181.35µs -1.25%
bench_hydration/Turbopack RCC/1000 modules 3699.10ms ± 8.82ms 3690.84ms ± 8.70ms -0.22%
bench_hydration/Turbopack RSC/1000 modules 3213.40ms ± 10.32ms 3220.71ms ± 10.17ms +0.23%
bench_hydration/Turbopack SSR/1000 modules 2986.90ms ± 12.59ms 2999.05ms ± 11.15ms +0.41%
bench_startup/Turbopack CSR/1000 modules 2083.92ms ± 14.44ms 2076.11ms ± 19.69ms -0.37%
bench_startup/Turbopack RCC/1000 modules 2464.91ms ± 8.90ms 2473.77ms ± 8.29ms +0.36%
bench_startup/Turbopack RSC/1000 modules 2410.94ms ± 9.51ms 2427.54ms ± 8.11ms +0.69%
bench_startup/Turbopack SSR/1000 modules 2069.45ms ± 6.06ms 2058.20ms ± 8.12ms -0.54%

@github-actions
Copy link
Contributor

🟢 CI successful 🟢

Thanks

@sokra sokra merged commit fe3ff76 into main Feb 1, 2023
@sokra sokra deleted the sokra/web-531-add-the-worker-condition-to-edge branch February 1, 2023 07:06
mehulkar pushed a commit that referenced this pull request Feb 1, 2023
@sokra @mehulkar
add worker condition to edge compilation (#3549)
c79c690 
some packages expect `worker` or `browser` condition to work on edge
runtime
@jridgewell jridgewell mentioned this pull request Feb 10, 2023
Merged
timneutkens pushed a commit to vercel/next.js that referenced this pull request Feb 10, 2023
@Brooooooklyn @kodiakhq
Update turbopack to 230209.02 (#45776)Co-authored-by: kodiakhq[bot] <…
946ccb0 
…49736102+kodiakhq[bot]@users.noreply.github.com>

# New Features
- vercel/turbo#3540
- vercel/turbo#3549
- vercel/turbo#3465
- vercel/turbo#3550
- vercel/turbo#3495
- vercel/turbo#3624
- vercel/turbo#3600
- vercel/turbo#3676
- vercel/turbo#3689

# Fixes

- vercel/turbo#3437
- vercel/turbo#3542
- vercel/turbo#3531
- vercel/turbo#3552
- vercel/turbo#3551
- vercel/turbo#3597
- vercel/turbo#3644
- vercel/turbo#3623
- vercel/turbo#3634
- vercel/turbo#3574
- vercel/turbo#3673
- vercel/turbo#3675
- vercel/turbo#3723
- vercel/turbo#3677
- vercel/turbo#3717
- vercel/turbo#3701

# Performance Improvements

- vercel/turbo#3361 
- vercel/turbo#3619

---------

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
jridgewell pushed a commit to vercel/next.js that referenced this pull request Mar 10, 2023
@sokra
add worker condition to edge compilation (vercel/turbo#3549)
eff285e 
some packages expect `worker` or `browser` condition to work on edge
runtime
sokra added a commit to vercel/next.js that referenced this pull request Mar 13, 2023
@sokra
add worker condition to edge compilation (vercel/turbo#3549)
d5de3a4 
some packages expect `worker` or `browser` condition to work on edge
runtime
@DuCanhGH DuCanhGH mentioned this pull request Mar 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ForsakenHarmony ForsakenHarmony ForsakenHarmony approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sokra @ForsakenHarmony