improve error reporting for fatal errors #3550

sokra · 2023-01-31T16:54:45Z

This adds the turbo-tasks function name as context of all fatal errors propagated from executing or reading turbo-tasks functions.

That should help in debugging fatal errors.

vercel · 2023-01-31T16:54:54Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
examples-vite-web	🔄 Building (Inspect)	Visit Preview		Feb 1, 2023 at 9:22PM (UTC)

9 Ignored Deployments

Name	Status	Preview	Updated
examples-basic-web	⬜️ Ignored (Inspect)	Visit Preview	Feb 1, 2023 at 9:22PM (UTC)
examples-cra-web	⬜️ Ignored (Inspect)	Visit Preview	Feb 1, 2023 at 9:22PM (UTC)
examples-designsystem-docs	⬜️ Ignored (Inspect)	Visit Preview	Feb 1, 2023 at 9:22PM (UTC)
examples-kitchensink-blog	⬜️ Ignored (Inspect)	Visit Preview	Feb 1, 2023 at 9:22PM (UTC)
examples-native-web	⬜️ Ignored (Inspect)	Visit Preview	Feb 1, 2023 at 9:22PM (UTC)
examples-nonmonorepo	⬜️ Ignored (Inspect)	Visit Preview	Feb 1, 2023 at 9:22PM (UTC)
examples-svelte-web	⬜️ Ignored (Inspect)	Visit Preview	Feb 1, 2023 at 9:22PM (UTC)
examples-tailwind-web	⬜️ Ignored (Inspect)	Visit Preview	Feb 1, 2023 at 9:22PM (UTC)
turbo-site	⬜️ Ignored (Inspect)	Visit Preview	Feb 1, 2023 at 9:22PM (UTC)

github-actions · 2023-01-31T17:59:03Z

Benchmark for `8061ade`

Click to view benchmark

Test	Base	PR	%
bench_hmr_to_commit/Turbopack CSR/1000 modules	8775.47µs ± 84.00µs	8782.87µs ± 47.41µs	+0.08%
bench_hmr_to_commit/Turbopack RCC/1000 modules	9045.05µs ± 83.05µs	9109.66µs ± 67.46µs	+0.71%
bench_hmr_to_commit/Turbopack RSC/1000 modules	468.82ms ± 0.80ms	465.32ms ± 1.85ms	-0.75%
bench_hmr_to_commit/Turbopack SSR/1000 modules	9022.13µs ± 79.14µs	9125.38µs ± 72.24µs	+1.14%
bench_hmr_to_eval/Turbopack CSR/1000 modules	7895.35µs ± 76.62µs	8036.82µs ± 53.12µs	+1.79%
bench_hmr_to_eval/Turbopack RCC/1000 modules	8079.13µs ± 69.01µs	8051.18µs ± 40.33µs	-0.35%
bench_hmr_to_eval/Turbopack SSR/1000 modules	8316.53µs ± 97.50µs	8165.95µs ± 78.25µs	-1.81%
bench_hydration/Turbopack RCC/1000 modules	3660.86ms ± 9.76ms	3672.73ms ± 10.45ms	+0.32%
bench_hydration/Turbopack RSC/1000 modules	3218.80ms ± 9.40ms	3186.43ms ± 9.45ms	-1.01%
bench_hydration/Turbopack SSR/1000 modules	2974.72ms ± 10.25ms	2989.10ms ± 8.36ms	+0.48%
bench_startup/Turbopack CSR/1000 modules	2012.70ms ± 10.92ms	1990.54ms ± 15.74ms	-1.10%
bench_startup/Turbopack RCC/1000 modules	2438.30ms ± 5.54ms	2443.71ms ± 7.56ms	+0.22%
bench_startup/Turbopack RSC/1000 modules	2321.31ms ± 6.07ms	2335.54ms ± 7.62ms	+0.61%
bench_startup/Turbopack SSR/1000 modules	1978.20ms ± 5.43ms	1982.69ms ± 4.02ms	+0.23%

github-actions · 2023-01-31T18:28:24Z

⚠️ CI failed ⚠️

The following steps have failed in CI:

Turbopack Rust tests

See workflow summary for details

github-actions · 2023-02-01T08:14:31Z

Benchmark for `05e7a9f`

Click to view benchmark

Test	Base	PR	%
bench_hmr_to_commit/Turbopack CSR/1000 modules	9607.18µs ± 84.30µs	9530.50µs ± 60.63µs	-0.80%
bench_hmr_to_commit/Turbopack RCC/1000 modules	10.08ms ± 0.09ms	9978.41µs ± 91.83µs	-1.03%
bench_hmr_to_commit/Turbopack RSC/1000 modules	475.71ms ± 2.87ms	479.88ms ± 3.00ms	+0.88%
bench_hmr_to_commit/Turbopack SSR/1000 modules	9836.04µs ± 68.23µs	9738.42µs ± 103.32µs	-0.99%
bench_hmr_to_eval/Turbopack CSR/1000 modules	8632.35µs ± 74.86µs	8525.90µs ± 69.08µs	-1.23%
bench_hmr_to_eval/Turbopack RCC/1000 modules	8717.85µs ± 43.88µs	8764.78µs ± 99.59µs	+0.54%
bench_hmr_to_eval/Turbopack SSR/1000 modules	8709.32µs ± 80.03µs	8800.13µs ± 76.11µs	+1.04%
bench_hydration/Turbopack RCC/1000 modules	3736.79ms ± 10.00ms	3756.28ms ± 13.48ms	+0.52%
bench_hydration/Turbopack RSC/1000 modules	3257.80ms ± 10.77ms	3281.26ms ± 11.93ms	+0.72%
bench_hydration/Turbopack SSR/1000 modules	3032.19ms ± 8.38ms	3061.83ms ± 10.67ms	+0.98%
bench_startup/Turbopack CSR/1000 modules	2036.75ms ± 12.80ms	2063.40ms ± 8.44ms	+1.31%
bench_startup/Turbopack RCC/1000 modules	2460.42ms ± 8.85ms	2487.87ms ± 8.20ms	+1.12%
bench_startup/Turbopack RSC/1000 modules	2368.77ms ± 7.11ms	2385.92ms ± 6.62ms	+0.72%
bench_startup/Turbopack SSR/1000 modules	2012.32ms ± 3.31ms	2018.53ms ± 3.91ms	+0.31%

github-actions · 2023-02-01T16:08:11Z

Benchmark for `fc1f40d`

Click to view benchmark

Test	Base	PR	%
bench_hmr_to_commit/Turbopack CSR/1000 modules	9156.70µs ± 69.63µs	9121.64µs ± 46.55µs	-0.38%
bench_hmr_to_commit/Turbopack RCC/1000 modules	9549.44µs ± 61.55µs	9493.86µs ± 65.73µs	-0.58%
bench_hmr_to_commit/Turbopack RSC/1000 modules	476.70ms ± 1.83ms	474.61ms ± 2.23ms	-0.44%
bench_hmr_to_commit/Turbopack SSR/1000 modules	9368.63µs ± 47.02µs	9373.74µs ± 82.88µs	+0.05%
bench_hmr_to_eval/Turbopack CSR/1000 modules	8191.27µs ± 81.13µs	8222.48µs ± 47.75µs	+0.38%
bench_hmr_to_eval/Turbopack RCC/1000 modules	8360.68µs ± 87.69µs	8407.26µs ± 85.38µs	+0.56%
bench_hmr_to_eval/Turbopack SSR/1000 modules	8558.87µs ± 51.91µs	8402.35µs ± 67.27µs	-1.83%
bench_hydration/Turbopack RCC/1000 modules	3706.12ms ± 8.92ms	3700.28ms ± 13.69ms	-0.16%
bench_hydration/Turbopack RSC/1000 modules	3233.86ms ± 12.14ms	3236.35ms ± 11.63ms	+0.08%
bench_hydration/Turbopack SSR/1000 modules	3006.92ms ± 8.65ms	3011.01ms ± 11.40ms	+0.14%
bench_startup/Turbopack CSR/1000 modules	2042.14ms ± 11.07ms	2039.29ms ± 8.34ms	-0.14%
bench_startup/Turbopack RCC/1000 modules	2459.75ms ± 7.48ms	2467.17ms ± 9.34ms	+0.30%
bench_startup/Turbopack RSC/1000 modules	2358.29ms ± 5.75ms	2368.69ms ± 4.56ms	+0.44%
bench_startup/Turbopack SSR/1000 modules	1994.02ms ± 6.61ms	1994.56ms ± 3.70ms	+0.03%

mehulkar

Guessing you need to pull in main. Bunch of turborepo tests being deleted and version number changing

cli/cmd/turbo/version.go

sokra · 2023-02-01T21:22:40Z

Guessing you need to pull in main. Bunch of turborepo tests being deleted and version number changing

yeah, something weird happened here... should be fixed now...

github-actions · 2023-02-01T22:32:12Z

Benchmark for `5a4e902`

Test	Base	PR	%	Significant %
bench_startup/Turbopack SSR/1000 modules	2095.71ms ± 3.58ms	2075.28ms ± 6.38ms	-0.98%	-0.02%

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	9411.91µs ± 78.51µs	9392.73µs ± 67.27µs	-0.20%
bench_hmr_to_commit/Turbopack RCC/1000 modules	9601.83µs ± 58.43µs	9589.21µs ± 77.91µs	-0.13%
bench_hmr_to_commit/Turbopack RSC/1000 modules	503.62ms ± 1.65ms	501.21ms ± 2.47ms	-0.48%
bench_hmr_to_commit/Turbopack SSR/1000 modules	9585.82µs ± 56.93µs	9536.04µs ± 88.86µs	-0.52%
bench_hmr_to_eval/Turbopack CSR/1000 modules	8485.58µs ± 82.27µs	8474.72µs ± 117.50µs	-0.13%
bench_hmr_to_eval/Turbopack RCC/1000 modules	8692.74µs ± 72.33µs	8655.67µs ± 51.79µs	-0.43%
bench_hmr_to_eval/Turbopack SSR/1000 modules	8631.33µs ± 82.70µs	8699.46µs ± 63.64µs	+0.79%
bench_hydration/Turbopack RCC/1000 modules	3886.87ms ± 9.44ms	3893.56ms ± 9.79ms	+0.17%
bench_hydration/Turbopack RSC/1000 modules	3409.80ms ± 13.47ms	3423.82ms ± 13.80ms	+0.41%
bench_hydration/Turbopack SSR/1000 modules	3172.69ms ± 9.32ms	3155.93ms ± 10.62ms	-0.53%
bench_startup/Turbopack CSR/1000 modules	2132.16ms ± 11.66ms	2090.08ms ± 15.19ms	-1.97%
bench_startup/Turbopack RCC/1000 modules	2558.20ms ± 10.52ms	2574.37ms ± 7.19ms	+0.63%
bench_startup/Turbopack RSC/1000 modules	2460.40ms ± 5.60ms	2475.29ms ± 5.64ms	+0.61%
bench_startup/Turbopack SSR/1000 modules	2095.71ms ± 3.58ms	2075.28ms ± 6.38ms	-0.98%	-0.02%

…49736102+kodiakhq[bot]@users.noreply.github.com> # New Features - vercel/turbo#3540 - vercel/turbo#3549 - vercel/turbo#3465 - vercel/turbo#3550 - vercel/turbo#3495 - vercel/turbo#3624 - vercel/turbo#3600 - vercel/turbo#3676 - vercel/turbo#3689 # Fixes - vercel/turbo#3437 - vercel/turbo#3542 - vercel/turbo#3531 - vercel/turbo#3552 - vercel/turbo#3551 - vercel/turbo#3597 - vercel/turbo#3644 - vercel/turbo#3623 - vercel/turbo#3634 - vercel/turbo#3574 - vercel/turbo#3673 - vercel/turbo#3675 - vercel/turbo#3723 - vercel/turbo#3677 - vercel/turbo#3717 - vercel/turbo#3701 # Performance Improvements - vercel/turbo#3361 - vercel/turbo#3619 --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

This adds the turbo-tasks function name as `context` of all fatal errors propagated from executing or reading turbo-tasks functions. That should help in debugging fatal errors.

The issue message emitted by `TryDotenvProcessEnv` was pretty bad: `Execution of TryDotenvProcessEnv::read_all failed`. This error message comes from #3550, which attaches the calling function as the context for every failed turbo function. This PR accomplishes 2 main things: 1. Expose an explicit method determining whether a the `DotenvEnvProcess`'s prior or current env failed 2. Detects a current env failure and uses the error's root cause for the issue message. <img width="961" alt="Screen Shot 2023-04-04 at 7 29 52 PM" src="https://user-images.githubusercontent.com/112982/229944525-d39dbe87-778a-4421-9bc8-632924cd3782.png"> Fixes WEB-851 Tests: vercel/next.js#47937

sokra requested a review from a team as a code owner January 31, 2023 16:54

github-actions bot added the area: turbopack label Jan 31, 2023

ForsakenHarmony approved these changes Jan 31, 2023

View reviewed changes

vercel bot deployed to Preview – examples-vite-web February 1, 2023 07:05 View deployment

vercel bot deployed to Preview – examples-tailwind-web February 1, 2023 07:05 View deployment

vercel bot deployed to Preview – examples-basic-web February 1, 2023 07:05 View deployment

vercel bot deployed to Preview – examples-svelte-web February 1, 2023 07:05 View deployment

vercel bot deployed to Preview – examples-native-web February 1, 2023 07:05 View deployment

vercel bot deployed to Preview – examples-designsystem-docs February 1, 2023 07:05 View deployment

vercel bot deployed to Preview – examples-kitchensink-blog February 1, 2023 07:05 View deployment

vercel bot deployed to Preview – examples-cra-web February 1, 2023 07:06 View deployment

vercel bot deployed to Preview – turbo-site February 1, 2023 07:06 View deployment

vercel bot deployed to Preview – examples-nonmonorepo February 1, 2023 07:06 View deployment

sokra added the pr: automerge Kodiak will merge these automatically after checks pass label Feb 1, 2023

sokra requested a review from a team as a code owner February 1, 2023 20:46

sokra requested review from mehulkar and tknickman February 1, 2023 20:46

github-actions bot added area: ci area: turborepo pkg: create-turbo Issues related to npx create-turbo pkg: turbo-ignore packages/turbo-ignore labels Feb 1, 2023

vercel bot deployed to Preview – turbo-site February 1, 2023 20:48 View deployment

mehulkar reviewed Feb 1, 2023

View reviewed changes

cli/cmd/turbo/version.go Outdated Show resolved Hide resolved

sokra added 2 commits February 1, 2023 22:12

improve error reporting

9227d89

add error origin chain

22fdc76

sokra added 4 commits February 1, 2023 22:12

improve error message

42f3142

move fatal error handling from JSON-only to ecmascript chunks in general

4af8c37

fix usage of context with errors

4105fb1

improve error reporting

47c05ad

sokra force-pushed the sokra/web-505-fatal-errors-should-include-turbo-tasks branch from 2727379 to 47c05ad Compare February 1, 2023 21:17

vercel bot deployed to Preview – turbo-site February 1, 2023 21:18 View deployment

add missing to_string impl

4f8989e

sokra merged commit 324c127 into main Feb 2, 2023

sokra deleted the sokra/web-505-fatal-errors-should-include-turbo-tasks branch February 2, 2023 05:53

jridgewell mentioned this pull request Feb 10, 2023

Update turbopack to 230209.02 vercel/next.js#45776

Merged

DuCanhGH mentioned this pull request Mar 15, 2023

Fix(typedRoutes): fixed files from directories other than pages and app getting into Route vercel/next.js#47184

Merged

jridgewell mentioned this pull request Apr 4, 2023

Better dotenv error messages #4464

Merged

gitworkflows mentioned this pull request Jan 18, 2024

[Snyk] Upgrade esbuild from 0.15.18 to 0.19.10 gsoc2/turbo#1

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

improve error reporting for fatal errors #3550

improve error reporting for fatal errors #3550

sokra commented Jan 31, 2023

vercel bot commented Jan 31, 2023 •

edited

github-actions bot commented Jan 31, 2023

github-actions bot commented Jan 31, 2023 •

edited

github-actions bot commented Feb 1, 2023

github-actions bot commented Feb 1, 2023

mehulkar left a comment

sokra commented Feb 1, 2023

github-actions bot commented Feb 1, 2023

improve error reporting for fatal errors #3550

improve error reporting for fatal errors #3550

Conversation

sokra commented Jan 31, 2023

vercel bot commented Jan 31, 2023 • edited

github-actions bot commented Jan 31, 2023

Benchmark for 8061ade

github-actions bot commented Jan 31, 2023 • edited

⚠️ CI failed ⚠️

github-actions bot commented Feb 1, 2023

Benchmark for 05e7a9f

github-actions bot commented Feb 1, 2023

Benchmark for fc1f40d

mehulkar left a comment

Choose a reason for hiding this comment

sokra commented Feb 1, 2023

github-actions bot commented Feb 1, 2023

Benchmark for 5a4e902

vercel bot commented Jan 31, 2023 •

edited

Benchmark for `8061ade`

github-actions bot commented Jan 31, 2023 •

edited

Benchmark for `05e7a9f`

Benchmark for `fc1f40d`

Benchmark for `5a4e902`